Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kustomize patchesStrategicMerge deprecation warning #2405

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Fix Kustomize patchesStrategicMerge deprecation warning #2405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions manifests/v2/third-party/jobset/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@ configMapGenerator:
disableNameSuffixHash: true

# Add required patches.
patchesStrategicMerge:
- patches/jobset_remove_namespace.yaml # Remove namespace from the JobSet release manifests.
- patches/jobset_config_patch.yaml # Add custom manager config to the JobSet.
patches:
# Remove namespace from the JobSet release manifests.
- path: patches/jobset_remove_namespace.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- path: patches/jobset_remove_namespace.yaml
- path: patches/jobset_remove_namespace.yaml
target:
group: xx
version: yy
kind: zz

Could we specify the target GVK to make the patch more declaratively?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leaned on the minimal fix, but I agree that'd be better with a target specified. I'm on it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. PTAL.

target:
group: ""
version: v1
kind: Namespace
# Add custom manager config to the JobSet.
- path: patches/jobset_config_patch.yaml
target:
group: apps
version: v1
kind: Deployment
Loading