Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2170: Deploy JobSet in kubeflow-system namespace #2388

Merged
merged 6 commits into from
Jan 27, 2025
Merged

KEP-2170: Deploy JobSet in kubeflow-system namespace #2388

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e99f1ce
KEP-2170: Deploy JobSet in kubeflow-system namespace
andreyvelich Jan 14, 2025
de9c1e2
Remove namespace from base
andreyvelich Jan 14, 2025
2d0fa6a
Remove label from namespace
andreyvelich Jan 14, 2025
6021349
Create third-party dir for JobSet
andreyvelich Jan 15, 2025
ce42837
Bump JobSet to v0.7.3
andreyvelich Jan 26, 2025
c78d980
Drop namespace from JobSet config
andreyvelich Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion manifests/v2/third-party/jobset/jobset_manager_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
apiVersion: config.jobset.x-k8s.io/v1alpha1
kind: Configuration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just using the default configuration would be sufficient.

https://github.com/kubernetes-sigs/jobset/blob/main/config/components/manager/controller_manager_config.yaml

I guess a nil configuration should be fine but it looks a bit weird.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way this is just a nit.

everything LGTM to me now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just keep this empty config, so in the future we can configure it.
I think, we can enable leader election in the future, if we want to have it by default.

namespace: kubeflow-system
1 change: 0 additions & 1 deletion manifests/v2/third-party/jobset/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ resources:
- https://github.com/kubernetes-sigs/jobset/releases/download/v0.7.3/manifests.yaml

# Config for the JobSet manager.
# TODO (andreyvelich): Remove this when this is released: https://github.com/kubernetes-sigs/jobset/issues/720
configMapGenerator:
- name: jobset-manager-config
files:
Expand Down
Loading