Skip to content

Conversation

@shadowinlife
Copy link
Contributor

Purpose of this PR

Proposed changes:

Add kube-scheduler podgroup unit tests to enhanced unit test. Details:

  • cover scheduler factory, scheduling, and cleanup code paths with the fake client
  • ensure PodGroup sync reuses the existing resourceVersion before issuing Update

After patch:

ok      github.com/kubeflow/spark-operator/v2/internal/scheduler/kubescheduler  3.039s  coverage: 86.5% of statements

I'd like to gradually contribute code to the current open-source project to improve test coverage, so that it can meet our internal usage standards

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

@google-oss-prow google-oss-prow bot requested review from ImpSy and nabuskey October 29, 2025 09:10
@shadowinlife shadowinlife force-pushed the unittest/add-kube-scheduler-unittest branch from 8155c3c to 36d605e Compare October 29, 2025 09:18
- cover scheduler factory, scheduling, and cleanup code paths with the fake client
- ensure PodGroup sync reuses the existing resourceVersion before issuing Update

Signed-off-by: 世行 <[email protected]>
@shadowinlife shadowinlife force-pushed the unittest/add-kube-scheduler-unittest branch from 36d605e to 6c37312 Compare October 29, 2025 09:19
@shadowinlife
Copy link
Contributor Author

@ChenYi015 this PR is ready for review. thanks

Copy link
Member

@ChenYi015 ChenYi015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shadowinlife Thanks for adding unit tests on kube-scheduler integration!
/approve

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChenYi015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f0aa139 into kubeflow:master Oct 30, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants