Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kubernetes 1.32 #2416

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacobsalway
Copy link
Member

@jacobsalway jacobsalway commented Feb 1, 2025

Purpose of this PR

Support Kubernetes 1.32

  • Remove replace directive and bump k8s.io/... dependencies to v0.32.0
  • Bump versions of controller-runtime, envtest and controller-tools to keep in sync with their upstream k8s.io/... compatibility
  • Add 1.32 to e2e test matrix and remove 1.28 to follow n-3 support policy
  • Small changes to use typed versions of some controller-runtime functions to fix build errors

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

@jacobsalway jacobsalway force-pushed the upgrade-to-kubernetes-1.32 branch 2 times, most recently from 7cbdb78 to 7cb3d06 Compare February 1, 2025 07:13
@google-oss-prow google-oss-prow bot added size/XXL and removed size/L labels Feb 1, 2025
@jacobsalway jacobsalway force-pushed the upgrade-to-kubernetes-1.32 branch from 7cb3d06 to 3309908 Compare February 1, 2025 11:56
Signed-off-by: Jacob Salway <[email protected]>
@jacobsalway jacobsalway force-pushed the upgrade-to-kubernetes-1.32 branch from 3309908 to 672e911 Compare February 1, 2025 12:16
@@ -1,7 +1,7 @@
run:
# Timeout for analysis, e.g. 30s, 5m.
# Default: 1m
timeout: 1m
timeout: 2m
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only takes 22s to execute on my local but was timing out in CI https://github.com/kubeflow/spark-operator/actions/runs/13088329194/job/36522115615?pr=2416

@jacobsalway jacobsalway marked this pull request as ready for review February 1, 2025 12:24
@google-oss-prow google-oss-prow bot requested a review from ChenYi015 February 1, 2025 12:24
@jacobsalway
Copy link
Member Author

/assign @vara-bonthu @ImpSy @ChenYi015

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Does this mean users with older versions of K8s (1.28) needs to stick with old tags when this is merged?

Have all tests been executed with these updates, and are there any known issues or regressions identified?

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants