Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): Add load_component_from_spec. Fixes #5708 #3748 #6690

Merged
merged 5 commits into from
Oct 28, 2021
Merged

feat(sdk): Add load_component_from_spec. Fixes #5708 #3748 #6690

merged 5 commits into from
Oct 28, 2021

Conversation

omarzouk
Copy link
Contributor

@omarzouk omarzouk commented Oct 6, 2021

Provide a function load_component_from_spec to allow loading of components from a ComponentSpec so users can describe a component in python directly without having to go to YAML first.

Fixes: #5708 and #3748

@google-cla
Copy link

google-cla bot commented Oct 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-oss-robot
Copy link

Hi @omarzouk. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@omarzouk
Copy link
Contributor Author

omarzouk commented Oct 6, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@omarzouk
Copy link
Contributor Author

omarzouk commented Oct 6, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 6, 2021
@ji-yaqi
Copy link
Contributor

ji-yaqi commented Oct 6, 2021

/ok-to-test

@omarzouk
Copy link
Contributor Author

omarzouk commented Oct 6, 2021

/retest-required

@omarzouk
Copy link
Contributor Author

omarzouk commented Oct 6, 2021

Hi @ji-yaqi the test keeps failing because of a timeout TimeoutError: Run timeout. I'm not sure what to do, I can't access the links in the logs (gives me a 403).

@omarzouk
Copy link
Contributor Author

/retest-required

@ji-yaqi
Copy link
Contributor

ji-yaqi commented Oct 18, 2021

Thanks @omarzouk for your PR! Could you add an entry in release notes in pipelines/sdk/RELEASE.md, and specify it for v1 change? Thanks!

@omarzouk
Copy link
Contributor Author

@ji-yaqi I have added the release notes

@omarzouk
Copy link
Contributor Author

/retest-required

@ji-yaqi
Copy link
Contributor

ji-yaqi commented Oct 27, 2021

/lgtm
/approve
Thanks @omarzouk!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ji-yaqi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

@omarzouk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 ebabdbc link unknown /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ji-yaqi
Copy link
Contributor

ji-yaqi commented Oct 28, 2021

Merging this since kubeflow-pipelines-samples-v2 is flaky.

@ji-yaqi ji-yaqi merged commit 3e6c776 into kubeflow:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Provide a kfp.components.load_component_from_dict function
3 participants