WIP: feat(backend): Add support for importing models stored in the Modelcar format (emptyDir copy) #11590
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
requested review from
Ark-kun,
DharmitD,
hbelmiro and
rimolive
mprahl
force-pushed
the
import-as-oci
branch
7 times, most recently
from
20c57ac to
062dbee
Compare
mprahl
changed the title
|
/cc @HumairAK |
mprahl
force-pushed
the
import-as-oci
branch
6 times, most recently
from
c911503 to
b020bcc
Compare
This allows dsl.import to leverage Modelcar container images in an OCI repository. This works by having any component container have an init container with the image set to the Modelcar container image and the /models directory contents copied to an emptyDir volume that is accessible in the component container. This approach has the benefit of leveraging image pull secrets configured on the Kubernetes cluster rather than require separate credentials for importing the artifact. Note that once Kubernetes supports OCI images as volume mounts for several releases, consider replacing the init container with that approach. Resolves: kubeflow#11584 Signed-off-by: mprahl <[email protected]>
|
Code LGTM, but it would be great if you can share instructions to test this PR as well as (if possible) provide additional documentation about this new feature with examples. |
|
/lgtm |
mprahl
changed the title
|
/hold considering the sidecar approach instead in #11606. |
Description of your changes:
This allows dsl.import to leverage Modelcar container images in an OCI repository. This works by having any component container have an init container with the image set to the Modelcar container image and the /models directory contents copied to an empty dir volume that is accessible in the component container.
This approach has the benefit of leveraging image pull secrets configured on the Kubernetes cluster rather than require separate credentials for importing the artifact.
Note that once Kubernetes supports OCI images as volume mounts for several releases, consider replacing the init container with that approach.
Resolves:
#11584
Checklist: