fix(CI): Use the correct image registry for replacements in integration tests #11564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @HumairAK |
HumairAK
reviewed
Jan 29, 2025
| @@ -5,13 +5,13 @@ resources: | |||
| - ../../../../manifests/kustomize/env/platform-agnostic | |||
|
|
|||
| images: | |||
| - name: gcr.io/ml-pipeline/api-server | |||
| - name: ghcr.io/kubeflow/kfp-api-server | |||
There was a problem hiding this comment.
tests are failing due to this change, I falsely assumed things were working but the old images were being used 🤦🏾 , so I'm guessing that's why the server is crashing
I think the issue is probably here
changing .[].file to .pipelines[].file should fix it, since the format of the samples json is now different
if it still fails let me know, this one probably falls on me to fix
There was a problem hiding this comment.
@HumairAK yup, my other PR adds logging to the failing pods (I'll shift that over here) and the log message is this:
I0129 02:20:31.147561 13 client_manager.go:216] Client manager initialized successfully
F0129 02:20:31.147947 13 main.go:82] Failed to load samples. Err: failed to load sample [Tutorial] Data passing in python components. Error: open /samples/tutorials/Data passing in python components/Data passing in python components - Files.py.yaml: no such file or directory
goroutine 1 [running]:
github.com/golang/glog.Fatalf(...)
/go/pkg/mod/github.com/golang/[email protected]/glog.go:690
main.main()
/go/src/github.com/kubeflow/pipelines/backend/src/apiserver/main.go:82 +0x2a9
SIGABRT: abort
PC=0x4098ae m=0 sigcode=18446744073709551610
mprahl
force-pushed
the
fix-ci-integration
branch
from
ca28de4 to
e4c5926
Compare
The image registry was changed to GitHub Container Registry in the 2.4 release. Signed-off-by: mprahl <[email protected]>
Signed-off-by: mprahl <[email protected]>
mprahl
force-pushed
the
fix-ci-integration
branch
2 times, most recently
from
9f3bcec to
9e24f4a
Compare
Signed-off-by: mprahl <[email protected]>
Signed-off-by: mprahl <[email protected]>
mprahl
force-pushed
the
fix-ci-integration
branch
from
9e24f4a to
f075efa
Compare
|
@mprahl ++ brilliant, thank you for the quick fix on this /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mholder6
pushed a commit
to mholder6/pipelines
that referenced
this pull request
Jan 31, 2025
Signed-off-by: Helber Belmiro <[email protected]> docs(backend): improved backend README (kubeflow#11511) * improved backend README Signed-off-by: Daniel Dowler <[email protected]> * Update backend/README.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Daniel Dowler <[email protected]> * Update backend/README.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Daniel Dowler <[email protected]> * Update backend/README.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Daniel Dowler <[email protected]> * Update backend/README.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Daniel Dowler <[email protected]> --------- Signed-off-by: Daniel Dowler <[email protected]> Co-authored-by: Helber Belmiro <[email protected]> fix(CI): Use the correct image registry for replacements in integration tests (kubeflow#11564) * Use the correct image registry for replacements in integration tests The image registry was changed to GitHub Container Registry in the 2.4 release. Signed-off-by: mprahl <[email protected]> * Print the pod logs when the pods fail to start in integration tests Signed-off-by: mprahl <[email protected]> * Fix the sample compilation in the API server container build Signed-off-by: mprahl <[email protected]> * Show the output when building the container images in CI Signed-off-by: mprahl <[email protected]> --------- Signed-off-by: mprahl <[email protected]> feat(api): Add SemaphoreKey and MutexName fields to proto (kubeflow#11384) Signed-off-by: ddalvi <[email protected]>
mholder6
pushed a commit
to mholder6/pipelines
that referenced
this pull request
Jan 31, 2025
Signed-off-by: Helber Belmiro <[email protected]> docs(backend): improved backend README (kubeflow#11511) * improved backend README Signed-off-by: Daniel Dowler <[email protected]> * Update backend/README.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Daniel Dowler <[email protected]> * Update backend/README.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Daniel Dowler <[email protected]> * Update backend/README.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Daniel Dowler <[email protected]> * Update backend/README.md Co-authored-by: Helber Belmiro <[email protected]> Signed-off-by: Daniel Dowler <[email protected]> --------- Signed-off-by: Daniel Dowler <[email protected]> Co-authored-by: Helber Belmiro <[email protected]> fix(CI): Use the correct image registry for replacements in integration tests (kubeflow#11564) * Use the correct image registry for replacements in integration tests The image registry was changed to GitHub Container Registry in the 2.4 release. Signed-off-by: mprahl <[email protected]> * Print the pod logs when the pods fail to start in integration tests Signed-off-by: mprahl <[email protected]> * Fix the sample compilation in the API server container build Signed-off-by: mprahl <[email protected]> * Show the output when building the container images in CI Signed-off-by: mprahl <[email protected]> --------- Signed-off-by: mprahl <[email protected]> feat(api): Add SemaphoreKey and MutexName fields to proto (kubeflow#11384) Signed-off-by: ddalvi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
The image registry was changed to GitHub Container Registry in the 2.4 release.
Checklist: