make commands

Signed-off-by: chahatsagarmain <[email protected]> fix Signed-off-by: chahatsagarmain <[email protected]> test Signed-off-by: chahatsagarmain <[email protected]> test ci Signed-off-by: chahatsagarmain <[email protected]>
kubeflow · Feb 6, 2025 · 3884fac · 3884fac
1 parent af4540e
commit 3884fac
Show file tree

Hide file tree

Showing 25 changed files with 420 additions and 252 deletions.
diff --git a/.github/actions/kfp-cluster/action.yml b/.github/actions/kfp-cluster/action.yml
@@ -19,8 +19,8 @@ runs:
 
     - name: Build images
       shell: bash
-      run: ./.github/resources/scripts/build-images.sh
+      run: make build-images
 
     - name: Deploy KFP
       shell: bash
-      run: ./.github/resources/scripts/deploy-kfp.sh
+      run: make deploy-kfp
diff --git a/.github/actions/kfp-tekton-cluster/action.yml b/.github/actions/kfp-tekton-cluster/action.yml
@@ -14,8 +14,8 @@ runs:
 
     - name: Build images
       shell: bash
-      run: ./.github/resources/scripts/build-images.sh
+      run: make build-images
 
     - name: Deploy KFP
       shell: bash
-      run: ./.github/resources/scripts/deploy-kfp-tekton.sh
+      run: make deploy-kfp-tekton
diff --git a/.github/workflows/backend-visualization.yml b/.github/workflows/backend-visualization.yml
@@ -23,4 +23,4 @@ jobs:
           python-version: '3.9'
 
       - name: Run tests
-        run: ./test/presubmit-backend-visualization.sh
+        run: make test-backend-visualization-test
diff --git a/.github/workflows/backend.yml b/.github/workflows/backend.yml
@@ -40,31 +40,24 @@ jobs:
           python-version: '3.9'
       - name: Install sdk
         run: |
-          python3 -m venv .venv
-          . .venv/bin/activate
-          pip install -e sdk/python
+          make setup-backend-test
       - name: Create KFP cluster
         uses: ./.github/actions/kfp-tekton-cluster
       - name: "flip coin test"
         run: |
-          . .venv/bin/activate
-          TEST_SCRIPT="test-flip-coin.sh" ./.github/resources/scripts/e2e-test.sh
+          make test-backend-test-flip-coin
       - name: "static loop test"
         run: |
-          . .venv/bin/activate
-          TEST_SCRIPT="test-static-loop.sh" ./.github/resources/scripts/e2e-test.sh
+          make test-backend-test-static-loop
       - name: "dynamic loop test"
         run: |
-          . .venv/bin/activate
-          TEST_SCRIPT="test-dynamic-loop.sh" ./.github/resources/scripts/e2e-test.sh
+          make test-backend-test-dynamic-loop
       - name: "use env"
         run: |
-          . .venv/bin/activate
-          TEST_SCRIPT="test-env.sh" ./.github/resources/scripts/e2e-test.sh
+          make test-backend-test-env
       - name: "use volume"
         run: |
-          . .venv/bin/activate
-          TEST_SCRIPT="test-volume.sh" ./.github/resources/scripts/e2e-test.sh
+          make test-backend-test-volume
       - name: Collect test results
         if: always()
         uses: actions/upload-artifact@v4

diff --git a/.github/workflows/e2e-test.yml b/.github/workflows/e2e-test.yml
@@ -37,12 +37,8 @@ jobs:
         with:
           k8s_version: ${{ matrix.k8s_version }}
 
-      - name: Forward API port
-        run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888
-
-      - name: Initialization tests v1
-        working-directory: ./backend/test/initialization
-        run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true
+      - name: Forward Port and initialize tests v1
+        run: make test-e2e-initialization-tests-v1
 
       - name: Collect test results
         if: always()
@@ -71,13 +67,8 @@ jobs:
         with:
           k8s_version: ${{ matrix.k8s_version }}
 
-
-      - name: Forward API port
-        run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888
-
       - name: Initialization tests v2
-        working-directory: ./backend/test/v2/initialization
-        run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true
+        run: make test-e2e-initialization-tests-v2
 
       - name: Collect test results
         if: always()
@@ -106,15 +97,8 @@ jobs:
         with:
           k8s_version: ${{ matrix.k8s_version }}
 
-      - name: Forward API port
-        run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888
-
-      - name: Forward MySQL port
-        run: ./.github/resources/scripts/forward-port.sh "kubeflow" "mysql" 3306 3306
-
       - name: API integration tests v1
-        working-directory: ./backend/test/integration
-        run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true
+        run:  make test-e2e-api-integration-tests-v1
 
       - name: Collect test results
         if: always()
@@ -143,13 +127,9 @@ jobs:
         with:
           k8s_version: ${{ matrix.k8s_version }}
 
-      - name: Forward API port
-        run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888
-
       - name: API integration tests v2
-        working-directory: ./backend/test/v2/integration
-        run: go test -v ./... -namespace kubeflow -args -runIntegrationTests=true
-
+        run: make test-e2e-api-integration-tests-v2
+
       - name: Collect test results
         if: always()
         uses: actions/upload-artifact@v4
@@ -177,19 +157,9 @@ jobs:
         with:
           k8s_version: ${{ matrix.k8s_version }}
 
-      - name: Forward API port
-        run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888
-
-      - name: Forward Frontend port
-        run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline-ui" 3000 3000
-
-      - name: Build frontend integration tests image
-        working-directory: ./test/frontend-integration-test
-        run: docker build . -t kfp-frontend-integration-test:local
-
-      - name: Frontend integration tests
-        run: docker run --net=host kfp-frontend-integration-test:local --remote-run true
-
+      - name: Forward API port and run integration test 
+        run: make test-e2e-frontend-integration-test
+
       - name: Collect test results
         if: always()
         uses: actions/upload-artifact@v4
@@ -217,18 +187,9 @@ jobs:
         with:
           k8s_version: ${{ matrix.k8s_version }}
 
-      - name: Forward API port
-        run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888
-
-      - name: Install prerequisites
-        run: pip3 install -r ./test/sample-test/requirements.txt
-
-      - name: Basic sample tests - sequential
-        run:  python3 ./test/sample-test/sample_test_launcher.py sample_test run_test --namespace kubeflow --test-name sequential --results-gcs-dir output
-
-      - name: Basic sample tests - exit_handler
-        run: python3 ./test/sample-test/sample_test_launcher.py sample_test run_test --namespace kubeflow --test-name exit_handler --expected-result failed --results-gcs-dir output
-
+      - name: Forward API port and run integration tests
+        run: make test-e2e-basic-sample-tests
+
       - name: Collect test results
         if: always()
         uses: actions/upload-artifact@v4

diff --git a/.github/workflows/frontend.yml b/.github/workflows/frontend.yml
@@ -24,12 +24,9 @@ jobs:
       with:
         node-version: '22'
 
-    - name: Clean npm cache
-      run: npm cache clean --force
-
-    - name: Install dependencies
-      run: cd ./frontend && npm ci
+    - name: Setup frontend test
+      run: make setup-frontend-test
 
     - name: Run Frontend Tests
-      run: cd ./frontend && npm run test:ci
+      run: make test-frontend
 
diff --git a/.github/workflows/gcpc-modules-tests.yml b/.github/workflows/gcpc-modules-tests.yml
@@ -21,36 +21,8 @@ jobs:
         with:
           python-version: 3.9
 
-      - name: apt-get update
-        run: sudo apt-get update
-
-      - name: Install protobuf-compiler
-        run: sudo apt-get install protobuf-compiler -y
-
-      - name: Install setuptools
-        run: | 
-          pip3 install setuptools
-          pip3 freeze
-
-      - name: Install Wheel
-        run: pip3 install wheel==0.42.0
-
-      - name: Install python sdk 
-        run: pip install sdk/python
-
-      - name: Generate API proto files
-        working-directory: ./api
-        run: make clean python
-
-      - name: Install kfp-pipeline-spec from source
-        run: | 
-          python3 -m pip install api/v2alpha1/python
-
-      - name: Install google-cloud component 
-        run: pip install components/google-cloud
-
-      - name: Install Pytest
-        run: pip install $(grep 'pytest==' sdk/python/requirements-dev.txt)
+      - name: Install requirements
+        run: make setup-grpc-modules-test
 
       - name: Run test
-        run: pytest ./test/gcpc-tests/run_all_gcpc_modules.py
+        run: make test-grpc-modules
diff --git a/.github/workflows/kfp-kubernetes-execution-tests.yml b/.github/workflows/kfp-kubernetes-execution-tests.yml
@@ -33,47 +33,8 @@ jobs:
         with:
           k8s_version: ${{ matrix.k8s_version }}
 
-      - name: Forward API port
-        run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888
+      - name: Install requirements 
+        run: make setup-kfp-kubernetes-execution-tests-without-kfp
 
-      - name: apt-get update
-        run: sudo apt-get update
-
-      - name: Install protobuf-compiler
-        run: sudo apt-get install protobuf-compiler -y
-
-      - name: Install setuptools
-        run: | 
-          pip3 install setuptools
-          pip3 freeze
-
-      - name: Install Wheel
-        run: pip3 install wheel==0.42.0
-
-      - name: Install protobuf
-        run: pip3 install protobuf==4.25.3
-
-      - name: Generate API proto files
-        working-directory: ./api
-        run: make clean python
-
-      - name: Install kfp-pipeline-spec from source
-        run: |
-          python3 -m pip install api/v2alpha1/python
-
-      - name: Generate kfp-kubernetes proto files from source
-        working-directory: ./kubernetes_platform
-        run: make clean python
-
-      - name: Install kfp-kubernetes from source
-        run: |
-          pip install -e ./kubernetes_platform/python[dev]
-
-      - name: Install requirements
-        run: pip install -r ./test/kfp-kubernetes-execution-tests/requirements.txt
-
-      - name: Run tests
-        run: |
-          export KFP_ENDPOINT="http://localhost:8888"
-          export TIMEOUT_SECONDS=2700
-          pytest ./test/kfp-kubernetes-execution-tests/sdk_execution_tests.py --asyncio-task-timeout $TIMEOUT_SECONDS
+      - name: Forward port and run tests
+        run: make test-kfp-kubernetes-execution-tests
diff --git a/.github/workflows/kfp-kubernetes-library-test.yml b/.github/workflows/kfp-kubernetes-library-test.yml
@@ -33,4 +33,4 @@ jobs:
           python-version: ${{matrix.python.version}}
 
       - name: Run tests
-        run: ./test/presubmit-test-kfp-kubernetes-library.sh
+        run: make test-kfp-kubernetes-library-test
diff --git a/.github/workflows/kfp-samples.yml b/.github/workflows/kfp-samples.yml
@@ -36,9 +36,6 @@ jobs:
       with:
         k8s_version: ${{ matrix.k8s_version }}
 
-    - name: Forward API port
-      run: ./.github/resources/scripts/forward-port.sh "kubeflow" "ml-pipeline" 8888 8888
-
-    - name: Run Samples Tests
+    - name: Forward port and run samples tests
       run: |
-        ./backend/src/v2/test/sample-test.sh
+        make test-kfp-samples
diff --git a/.github/workflows/kfp-sdk-runtime-tests.yml b/.github/workflows/kfp-sdk-runtime-tests.yml
@@ -28,4 +28,4 @@ jobs:
       - name: Run KFP Runtime Code Tests
         run: |
           export PULL_NUMBER="${{ github.event.inputs.pull_number || github.event.pull_request.number }}"
-          ./test/presubmit-test-kfp-runtime-code.sh
+          make test-kfp-sdk-runtime-tests
diff --git a/.github/workflows/kfp-sdk-tests.yml b/.github/workflows/kfp-sdk-tests.yml
@@ -27,5 +27,4 @@ jobs:
         python-version: ${{ matrix.python }}
 
     - name: Run SDK Tests
-      run: |
-        ./test/presubmit-tests-sdk.sh
+      run: make test-kfp-sdk-tests
diff --git a/.github/workflows/kubeflow-pipelines-manifests.yml b/.github/workflows/kubeflow-pipelines-manifests.yml
@@ -16,4 +16,4 @@ jobs:
         uses: actions/checkout@v4    
 
       - name: Run tests
-        run: ./manifests/kustomize/hack/presubmit.sh 
+        run: make test-kubeflow-pipelines-manifests
diff --git a/.github/workflows/periodic.yml b/.github/workflows/periodic.yml
@@ -22,13 +22,10 @@ jobs:
         uses: ./.github/actions/kfp-cluster
         with:
           k8s_version: ${{ matrix.k8s_version }}
-      - name: Port forward kfp apiserver
-        run: |
-          nohup kubectl port-forward --namespace kubeflow svc/ml-pipeline 8888:8888 &
-      - name: Run Functional Tests
-        run: |
-          log_dir=$(mktemp -d)
-          ./test/kfp-functional-test/kfp-functional-test.sh > $log_dir/periodic_tests.txt
+
+      - name: Port forward and run Functional Tests
+        run: make test-periodic-test
+
       - name: Collect test results
         if: always()
         uses: actions/upload-artifact@v4

diff --git a/.github/workflows/presubmit-backend.yml b/.github/workflows/presubmit-backend.yml
@@ -10,6 +10,7 @@ on:
     paths:
       - 'backend/**'
       - 'test/presubmit-backend-test.sh'
+      - '.github/workflows/presubmit-backend.yml'
 
 jobs:
   backend-tests:
@@ -25,4 +26,4 @@ jobs:
         go-version-file: go.mod
 
     - name: Run Backend Tests
-      run: ./test/presubmit-backend-test.sh
+      run: make test-presubmit-backend
diff --git a/.github/workflows/sdk-component-yaml.yml b/.github/workflows/sdk-component-yaml.yml
@@ -24,33 +24,8 @@ jobs:
         with:
           python-version: 3.9
 
-      - name: apt-get update
-        run: sudo apt-get update
-
-      - name: Install protobuf-compiler
-        run: sudo apt-get install protobuf-compiler -y
-
-      - name: Install setuptools
-        run: | 
-          pip3 install setuptools
-          pip3 freeze
-
-      - name: Install Wheel
-        run: pip3 install wheel==0.42.0
-
-      - name: Install protobuf
-        run: pip3 install protobuf==4.25.3
-
-      - name: Generate API proto files
-        working-directory: ./api
-        run: make clean python
-
-      - name: Install kfp-pipeline-spec from source
-        run: |
-          python3 -m pip install api/v2alpha1/python
-
       - name: Install requirements
-        run: pip install -r ./test/sdk-execution-tests/requirements.txt
+        run: make setup-sdk-component-yaml
 
       - name: Run component YAML tests
-        run: ./test/presubmit-component-yaml.sh
+        run: make test-sdk-component-yaml
diff --git a/.github/workflows/sdk-docformatter.yml b/.github/workflows/sdk-docformatter.yml
@@ -23,4 +23,4 @@ jobs:
           python-version: 3.9
 
       - name: Run docformatter tests
-        run: ./test/presubmit-docformatter-sdk.sh
+        run: make test-sdk-docformatter