Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add issue templates and contributing guide #4

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ederign
Copy link
Member

@ederign ederign commented May 9, 2024

@ederign
Copy link
Member Author

ederign commented May 9, 2024

@thesuperzapper ^

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
ederign and others added 3 commits May 29, 2024 07:03
Co-authored-by: Jiri Daněk <[email protected]>
Co-authored-by: Jiri Daněk <[email protected]>
Co-authored-by: Jiri Daněk <[email protected]>
@ederign
Copy link
Member Author

ederign commented May 29, 2024

@jiridanek @thesuperzapper, do you think we can merge this as a starting point?

@ederign ederign requested a review from jiridanek May 29, 2024 12:08
value: |
# Bug Report

Thanks for helping make the Kubeflow Notebooks project better!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Thanks for helping make the Kubeflow Notebooks project better!
Thanks for helping to make the Kubeflow Notebooks project better!


The contributor's guide

* shows you where to find the Contributor License Agreement (CLA) that you need
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* shows you where to find the Contributor License Agreement (CLA) that you need

We have https://developercertificate.org/, not cla. Cla is evil.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ederign btw, don't forget to sign commits ;P

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Jiri Daněk <[email protected]>
Signed-off-by: Eder Ignatowicz <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jiridanek
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

feat(ws): my commit message`

Signed-off-by: John Smith <[email protected]>
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no new line at the end of file

@thesuperzapper thesuperzapper added the area/docs area - related to documentation label Jul 18, 2024
@thesuperzapper thesuperzapper self-assigned this Jul 18, 2024
@thesuperzapper thesuperzapper modified the milestone: Repo Setup Jul 18, 2024
@thesuperzapper thesuperzapper added the project/repo-setup project - repo setup and health label Jul 18, 2024
@thesuperzapper thesuperzapper changed the title add CONTRIBUTING.md, pull_request_template.md and ISSUE_TEMPLATE. chore: add issue templates and contributing guide Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs area - related to documentation project/repo-setup project - repo setup and health size/L
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants