feat(ws): Notebooks 2.0 // Frontend // Workspaces table // Workspace redirect status column #147

[asaadbalum]

When Info/Warning/Danger redirection level:

When no BE response:

When wrong redirection level:

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• workspaces/frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ederign]

/assign @paulovmr

[ederign]

@asaadbalum thanks for the PR! @paulovmr can you please take a look on it?

Meanwhile, @asaadbalum can you fix the PR title for semantic values and also sign the commits (DCO check)?

[asaadbalum]

@asaadbalum thanks for the PR! @paulovmr can you please take a look on it?

Meanwhile, @asaadbalum can you fix the PR title for semantic values and also sign the commits (DCO check)?

Is if fine now?

[paulovmr]

Hi @asaadbalum , to fix the semantic PRs check, your PR title needs to have a prefix following the Conventional commits specification. For notebooks 2.0 tasks, the scope is "ws", a reference to "workspaces". Therefore, the majority of pull request we are sending would have a name like "feat(ws): ". Considering that, if you add the "feat(ws): " prefix to your PR title, it should be fixed.

To fix the DCO check, you need to sign off your commits. There is information here with a few options on how to do it.

Also, everytime before submitting a PR, please consider running npm run test to check for linting and tests errors. Most of the formatting issues can be solved automatically with npm run test:fix.