Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ws): Notebooks 2.0 // Frontend // Workspace details // Applies MUI Theming #185

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

jenny-s51
Copy link

@jenny-s51 jenny-s51 commented Jan 23, 2025

Adds MUI support to Notebooks 2.0 UI. Applies theming to Workspace details drawer to align with MUI theming and KF Central UI.

Before:
Screenshot 2025-01-23 at 4 05 18 PM

After:
Screenshot 2025-01-24 at 12 11 21 PM

MUI Responsive Drawer:
Screenshot 2025-01-23 at 4 38 04 PM

KF Central UI (Aligns with list styling in "Overview" tab):
Screenshot 2025-01-23 at 4 20 42 PM

Copy link
Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converting to draft while design details are still being discussed and confirmed.

@jenny-s51 jenny-s51 marked this pull request as ready for review January 24, 2025 16:30
Signed-off-by: Jenny <[email protected]>

fix tab content padding

apply horizontal variant to description list, add dividers to match KF central UI

update spacer size

Signed-off-by: Jenny <[email protected]>

update font size for description list term
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, paulovmr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Jan 24, 2025

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 24, 2025
@google-oss-prow google-oss-prow bot merged commit 6fe7716 into kubeflow:notebooks-v2 Jan 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants