feat(ws): add filter to workspaces table #157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ElayAharoni
force-pushed
the
RHOAIENG-16233-Filter-workspaces
branch
4 times, most recently
from
0ad2045 to
fd2eb6f
Compare
thesuperzapper
changed the title
ElayAharoni
force-pushed
the
RHOAIENG-16233-Filter-workspaces
branch
from
fd2eb6f to
47b4fac
Compare
ElayAharoni
force-pushed
the
RHOAIENG-16233-Filter-workspaces
branch
3 times, most recently
from
5764a02 to
cdd8587
Compare
Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
ElayAharoni
force-pushed
the
RHOAIENG-16233-Filter-workspaces
branch
from
cdd8587 to
7a34836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #143.
extracted filtering logic into different generic Filter component.
implemented logic for filtering with single filter and multiple filters, including adding and removing.
cleaned the workspaces file code a little bit with inserting looping over data.
added cypress tests for the filtering.
made minor change in the cypress.config file in order to be able to see changes in the ui immidiatly on the cypress gui and make testing more easy, so we dont need to do build on each change in order to see it on cypress.