feat(ws): add namespace dropdown to UI

[YosiElias]

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ederign for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• workspaces/frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[paulovmr]

Hi @YosiElias , thanks for the PR! I added a few comments inline, and I would like to ask you a few things to align this PR with the Kubeflow contributing guide and to make the review easier:

• I can see a few extra commits in this PR's branch, please consider adding just the one related to your changes, with your sign-off.
• To follow the commit naming convention, please consider having the text "feat(ws): Notebooks 2.0 // Frontend // Namespace selector" for the commit message and PR label.

Also please consider adding some Cypress tests to automate the namespace changing verification. Thanks!

[paulovmr]

IMHO, the useEffect could be used directly, without this hook.

[asaadbalum]

It is a preparation for future useEffect calls without dependencies, meaning, it's much for "readable" and compact this way in our opinion (one line simple call wrapping a function, instead of whole useEffect syntax)
If you still think a direct useEffect call is better, we will refactor it back.

[Griffin-Sullivan]

If you make the changes I suggested, you can then run the following in the frontend/ dir:

npm run test:fix

and that should fix your CI failure.

[Griffin-Sullivan]

Suggested change

	}, []);
	});

[YosiElias]

@Griffin-Sullivan thanks for you comments!
I have a question, why would you want to remove the dependencies array?
If we do that, it’ll run after every render (and re-render), but we only want it to run on the first render, don’t we? (that was the intention of useMount)