-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ws): update list workspacekinds JSON payloads #138
base: notebooks-v2
Are you sure you want to change the base?
Conversation
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Yehudit Kerido <[email protected]>
Signed-off-by: Yehudit Kerido <[email protected]>
Signed-off-by: Yehudit Kerido <[email protected]>
Signed-off-by: Yehudit Kerido <[email protected]>
Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi guys, sorry for the lack of clear specification. And thanks for the first PR.
I've updated #128 with the payload needed for this task. Could you please update it!
Signed-off-by: Yehudit Kerido <[email protected]>
Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
Signed-off-by: Liav Weiss (EXT-Nokia) <[email protected]>
Signed-off-by: Yehudit Kerido <[email protected]>
Signed-off-by: yehudit1987 <[email protected]>
New output: |
Signed-off-by: Yehudit Kerido <[email protected]>
Resolution details for #128.
We investigate this issue with referring to payload example provided in #127 .
Seems the example is not relevant with all it's fields to workspacekind resource.
Currently the output for the sample yaml as resource input (jupyterlab_v1beta1_workspacekind.yaml) -
curl -i localhost:4000/api/v1/workspacekinds
{
"data":[
{
"name":"jupyterlab",
"spawner":{
"display_name":"JupyterLab Notebook",
"description":"A Workspace which runs JupyterLab in a Pod",
"deprecated":false,
"deprecation_message":"This WorkspaceKind will be removed on 20XX-XX-XX, please use another WorkspaceKind.",
"hidden":false
},
"pod_template":{
"pod_metadata":{
"labels":{
"my-workspace-kind-label":"my-value"
},
"annotations":{
"my-workspace-kind-annotation":"my-value"
}
},
"image_config":{
"current":"jupyterlab_scipy_190",
"desired":"jupyterlab_scipy_190",
"redirect_chain":[
{
"source":"jupyterlab_scipy_180",
"target":"jupyterlab_scipy_190"
}
]
},
"pod_config":{
"current":"tiny_cpu",
"desired":"tiny_cpu",
"redirect_chain":[
{
"source":"tiny_cpu",
"target":"tiny_cpu"
},
{
"source":"tiny_cpu",
"target":"small_cpu"
},
{
"source":"tiny_cpu",
"target":"big_gpu"
}
]
}
}
}
]
}