-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(ws): run make test-e2e
on GitHub Actions
#11
ci(ws): run make test-e2e
on GitHub Actions
#11
Conversation
/lgtm |
e93bf78
to
96fcdc1
Compare
As per @thesuperzapper 's suggestion, I put in explicit kind version. Here's the CI running https://github.com/jiridanek/notebooks-v2/actions/runs/9602645980/job/26483942380 |
Signed-off-by: Jiri Daněk <[email protected]>
Signed-off-by: Jiri Daněk <[email protected]>
Signed-off-by: Jiri Daněk <[email protected]>
96fcdc1
to
fe8ad19
Compare
Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
@jiridanek now that we have actual end-to-end tests (added in #30), I have rebased this PR and cleaned it up a little in 3e8beea and 7408921. We should be good to merge now, so that tests run automatically on every PR for the controller. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is something that works differently in new Kubebuilder, compared to what's in kubeflow/kubeflow notebook controller.
Previously, what they called e2e tests was running in envtest, but currently they expect to run in externally-provided kind. So, let's run this on CI as well, so we don't have dead code.