Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSOC] optuna suggestion service logic update #2446

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shashank-iitbhu
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2374

Checklist:

  • Docs included if any changes are user facing

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mahdikhashan
Copy link
Contributor

I started reviewing this pr

cc: @andreyvelich

@mahdikhashan
Copy link
Contributor

/rerun-all

@mahdikhashan
Copy link
Contributor

@shashank-iitbhu would you please rerun the ci?

@shashank-iitbhu shashank-iitbhu force-pushed the feat/optuna-suggestion-service-update branch from edf98f0 to f263b26 Compare January 30, 2025 10:36
@shashank-iitbhu shashank-iitbhu marked this pull request as ready for review January 30, 2025 10:40
@shashank-iitbhu
Copy link
Contributor Author

@mahdikhashan still working on this PR, need some time. This is based on #2412 , so it makes sense to merge this once #2412 is merged.

@mahdikhashan
Copy link
Contributor

@mahdikhashan still working on this PR, need some time. This is based on #2412 , so it makes sense to merge this once #2412 is merged.

ok, take your time, are there any place which I can offer you help?

@Electronic-Waste
Copy link
Member

Hi @shashank-iitbhu, #2412 has been merged. We can work on this now!

But before that, could you please rebase your PR and resolve the errors in CI?

@mahdikhashan
Copy link
Contributor

Hi @shashank-iitbhu, #2412 has been merged. We can work on this now!

But before that, could you please rebase your PR and resolve the errors in CI?

@shashank-iitbhu shall we start reviewing it?

shashank-iitbhu and others added 4 commits February 3, 2025 18:13
Signed-off-by: Shashank Mittal <[email protected]>
Co-authored-by: Yuki Iwai <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
@shashank-iitbhu shashank-iitbhu force-pushed the feat/optuna-suggestion-service-update branch from f263b26 to 6b18e9b Compare February 3, 2025 12:46
@google-oss-prow google-oss-prow bot added size/M and removed size/XL labels Feb 3, 2025
@shashank-iitbhu
Copy link
Contributor Author

Hi @shashank-iitbhu, #2412 has been merged. We can work on this now!
But before that, could you please rebase your PR and resolve the errors in CI?

@shashank-iitbhu shall we start reviewing it?

Sure, I have rebased this PR also, I will let you know once this is ready for review.

@mahdikhashan
Copy link
Contributor

Hi @shashank-iitbhu, #2412 has been merged. We can work on this now!
But before that, could you please rebase your PR and resolve the errors in CI?

@shashank-iitbhu shall we start reviewing it?

Sure, I have rebased this PR also, I will let you know once this is ready for review.

thank you! feel free to ping me when you're ready. btw, we can also do a progressive review. would it work for you to review the existing code before finalizing it?

@andreyvelich
Copy link
Member

Hi @shashank-iitbhu, we have time until this Wednesday to merge this PR before we cut Katib RC.0.
Do you have enough time to finish it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GSOC] Project 8: Support various Parameter Distribution in Katib
4 participants