-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSOC] optuna
suggestion service logic update
#2446
base: master
Are you sure you want to change the base?
[GSOC] optuna
suggestion service logic update
#2446
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I started reviewing this pr cc: @andreyvelich |
/rerun-all |
@shashank-iitbhu would you please rerun the ci? |
edf98f0
to
f263b26
Compare
@mahdikhashan still working on this PR, need some time. This is based on #2412 , so it makes sense to merge this once #2412 is merged. |
ok, take your time, are there any place which I can offer you help? |
Hi @shashank-iitbhu, #2412 has been merged. We can work on this now! But before that, could you please rebase your PR and resolve the errors in CI? |
@shashank-iitbhu shall we start reviewing it? |
Signed-off-by: Shashank Mittal <[email protected]>
Co-authored-by: Yuki Iwai <[email protected]> Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
f263b26
to
6b18e9b
Compare
Sure, I have rebased this PR also, I will let you know once this is ready for review. |
thank you! feel free to ping me when you're ready. btw, we can also do a progressive review. would it work for you to review the existing code before finalizing it? |
Hi @shashank-iitbhu, we have time until this Wednesday to merge this PR before we cut Katib RC.0. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2374
Checklist: