Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC] Add e2e test for
tune
api with LLM hyperparameter optimization #2420base: master
Are you sure you want to change the base?
[GSoC] Add e2e test for
tune
api with LLM hyperparameter optimization #2420Changes from 55 commits
6be7f29
1a1f119
8461a49
c860238
216ebd9
f6b96f5
c636493
8180422
6101489
d67a1b8
295abb6
e0a1b6d
1df7df9
d1e1311
0cc319f
0383932
08c8634
7a98a00
8862d79
e4f614d
0385eea
e0c5170
0286f70
f6e5ed5
7ea7e43
25d99b1
fcd64fa
122c611
c1fde09
8ff6864
da3c298
a1bff26
bbae57b
e45ceac
4ae11ed
bedab36
7bfb3cc
efffdc2
2a18b17
c6c964b
28ffb96
dc684e3
a12034c
b088815
e468b27
64d8fef
45db42e
c6e91cd
b1a2390
e5bf840
fca94ae
b5cae0d
a785d35
865379e
d1ea629
5e2e44f
982e268
55c404d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest importing each e2e specific requirements inside its function, for example:
in this way, the scope of each test is more determined - WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we link an updated guide for Katib LLM Optimization ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the Katib LLM Optimization guide is still under review, should I link to the file in its current state for now?
Additionally, the example in the Katib LLM Optimization guide uses a different model and dataset compared to this one. The guide uses the LLaMa model, which requires access tokens. I’ve already applied for the access token and am awaiting approval. Once I receive it, I will test the example to see if it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried running the above example, but I ran into some unexpected errors in the
storage_initializer
container, and the model couldn't be downloaded successfully. It seems like the model used in this example might require different versions of transformers or other libraries. I'll look into it, but it might take some time to resolve.If we aim to include this in Katib 0.18-rc.0 this week, we might need to stick with the current example. Otherwise, I’ll work on fixing it before RC.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, it is fine to include it in RC.1 since it is a bug fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can keep URL for Kubeflow Training docs for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest we using a prettifier to format the result of the test success of failure here, for example using pprint. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest we using a simpler iterate over a data structure like the unit-tests, for example:
WDYT?