Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating changes to Approver and Reviewer #591

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updating changes to Approver and Reviewer #591

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e039bcf
Updating changes to Approver and Reviewer
jbottum Dec 12, 2022
69ae8fd
changed Review and Approver requirements
jbottum Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions wgs/community-membership.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ The following apply to the part of codebase for which one would be a reviewer in
an [OWNERS] file (for repos using the bot).

- member for at least 3 months
- Primary reviewer for at least 5 PRs to the codebase
- Reviewed or merged at least 20 substantial PRs to the codebase
- Primary reviewer for at least 3 PRs to the codebase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 substantial PRs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I changed in "Reviewer for or author of at least 5 substantial PRs to the codebase" in 2nd commit

- Reviewed or merged at least 5 substantial PRs to the codebase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would clarify what substantial means:

Perhaps add something like "with the definition of substantial subject to the lead's discretion (e.g. refactors, enhancements rather than grammar correction or one-line pulls)" similar to what we are doing at Argo project.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. As in the Argo doc, we can also combine these 2 points to one Reviewer for or author of at least 5 substantial PRs to the codebase,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Johnu's wording.

Copy link
Contributor Author

@jbottum jbottum Jan 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I changed to "Reviewer for or author of at least 5 substantial PRs to the codebase" in 2nd commit

- Knowledgeable about the codebase
- Sponsored by a subproject approver
- With no objections from other approvers
Expand Down Expand Up @@ -139,8 +139,8 @@ The following apply to the part of codebase for which one would be an approver
in an [OWNERS] file (for repos using the bot).

- Reviewer of the codebase for at least 3 months
- Primary reviewer for at least 10 substantial PRs to the codebase
- Reviewed or merged at least 30 PRs to the codebase
- Primary reviewer for at least 5 substantial PRs to the codebase
- Reviewed or merged at least 10 PRs to the codebase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only mentioned reviewing PRs. I think we want to promote people who actually authored substantial PRs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Similar comment as before. Combining to one, Reviewer for or author of at least 10 substantial PRs to the codebase

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to Johnu's wording.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I updated to "Reviewer for or author of at least 5 substantial PRs to the codebase" in 2nd commit

- Nominated by a subproject owner
- With no objections from other subproject owners
- Done through PR to update the top-level OWNERS file
Expand Down Expand Up @@ -215,4 +215,4 @@ The following apply to the subproject for which one would be an owner.
[New contributors]: https://www.kubeflow.org/docs/about/contributing/
[OWNERS]: https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md
[wgs.yaml]: templates/wgs.yaml
[two-factor authentication]: https://help.github.com/articles/about-two-factor-authentication
[two-factor authentication]: https://help.github.com/articles/about-two-factor-authentication