refactor tarian #54
refactor tarian #54
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) | ||
|
|
||
| const ( | ||
| defaultServerAddress = "localhost:50051" |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling.
| cmd.Flags().StringVar(&o.host, "host", defaultHost, "The host to listen on") | ||
| cmd.Flags().StringVar(&o.port, "port", defaultPort, "The port to listen on") | ||
|
|
||
| cmd.Flags().StringVar(&o.alertManagerAddress, "alertmanager-address", "", "Alert manager address to send alerts to. For example: http://localhost:9093. Setting this enables alerting") |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling.
| podAgent := podagent.NewPodAgent("localhost:" + e2eClusterAgentPort) | ||
| clusterAgent, err := clusteragent.NewClusterAgent(log.GetLogger(), clusterAgentConfig) | ||
| require.Nil(t, err) | ||
| podAgent := podagent.NewPodAgent(log.GetLogger(), "localhost:"+e2eClusterAgentPort) |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling.
| defaultPort = "50052" | ||
| defaultHost = "" | ||
|
|
||
| defaultServerAddress = "localhost:50051" |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling.
| // Add flags | ||
| runWebhookServerCmd.Flags().IntVar(&cmd.port, "port", 9443, "Webhook server port") | ||
| runWebhookServerCmd.Flags().StringVar(&cmd.podAgentContainerName, "pod-agent-container-name", "tarian-pod-agent", "Pod agent container name to be injected") | ||
| runWebhookServerCmd.Flags().StringVar(&cmd.podAgentContainerImage, "pod-agent-container-image", "localhost:5000/tarian-pod-agent:latest", "Pod agent container image to be injected") |
Check notice
Code scanning / devskim
Accessing localhost could indicate debug code, or could hinder scaling.
pratikjagrut
force-pushed
the
refactor.tarian
branch
from
87c1adb
to
be7f3a4
Compare
pratikjagrut
force-pushed
the
refactor.tarian
branch
from
be7f3a4
to
e93fa71
Compare
pratikjagrut
force-pushed
the
refactor.tarian
branch
from
e93fa71
to
01a94ac
Compare
|
|
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
pratikjagrut
force-pushed
the
refactor.tarian
branch
6 times, most recently
from
976d4ba
to
bc7ebf3
Compare
|
@andylibrian , please check this PR. @pratikjagrut @pratikjagrut, have you tested all the changes before submitting this PR? I'm just confirming. |
pratikjagrut
force-pushed
the
refactor.tarian
branch
from
bc7ebf3
to
ba9da80
Compare
pratikjagrut
force-pushed
the
refactor.tarian
branch
from
ba9da80
to
c730820
Compare
This pull request brings significant changes by revamping the CLIs using cobra. It also incorporates a new logging and error mechanism, enhancing the overall functionality and user experience.