Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts,manifests: Support configuring Presto hive.s3.use-instance-credentials Hive catalog config property #991

Merged
merged 1 commit into from
Oct 29, 2019
Merged

charts,manifests: Support configuring Presto hive.s3.use-instance-credentials Hive catalog config property #991

merged 1 commit into from
Oct 29, 2019

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Oct 17, 2019 •
edited
Loading

Partial fix for #947

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2019
@chancez
Copy link
Contributor Author

chancez commented Oct 17, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2019
charts,manifests: Support configuring Presto hive.s3.use-instance-cre…
8567eb0 
…dentials Hive catalog config property

Partial fix for kube-reporting#947
@chancez chancez force-pushed the presto_hive_instance_creds branch from b3f7147 to 8567eb0 Compare October 17, 2019 17:44
@chancez
Copy link
Contributor Author

chancez commented Oct 17, 2019

/retest

2 similar comments
@chancez
Copy link
Contributor Author

chancez commented Oct 17, 2019

/retest

@chancez
Copy link
Contributor Author

chancez commented Oct 18, 2019

/retest

@chancez
Copy link
Contributor Author

chancez commented Oct 28, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2019
timflannagan
timflannagan approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chancez, timflannagan1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 49435ce into kube-reporting:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timflannagan timflannagan timflannagan approved these changes

@bentito bentito Awaiting requested review from bentito

Assignees

@timflannagan timflannagan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chancez @openshift-ci-robot @timflannagan @openshift-merge-robot