Warn contributors: README is generated #919
Conversation
| @@ -44,7 +44,8 @@ final class ReadmeCommand extends Command | |||
| protected function execute(InputInterface $input, OutputInterface $output): int | |||
| { | |||
| $output->write( | |||
| \sprintf('# %s', self::NAME) . "\n\n" | |||
| '<!-- This files is generated by ReadmeCommand -->' . "\n\n" | |||
There was a problem hiding this comment.
| '<!-- This files is generated by ReadmeCommand -->' . "\n\n" | |
| '<!-- This file is generated by ReadmeCommand -->' . "\n\n" |
There was a problem hiding this comment.
That was my autonomous finger!
There was a problem hiding this comment.
Probably needs a rebase on top of main following #918, @szepeviktor!
There was a problem hiding this comment.
I think README needs to be regenerated.
I let you guys do that.
There was a problem hiding this comment.
I think README needs to be regenerated.
That wouldn't be enough, as analyse job is failing with code style violation. Also, that comment won't be displayed: https://github.com/6b7562617765726c6f73/php-cs-fixer-custom-fixers/tree/test_readme_with_html_comment
I believe the problem is NOT that README.md is generated, but not checking failing CI's jobs in PR. I've added message to the check with information what to do.
Co-authored-by: Andreas Möller <[email protected]>
Pull Request Test Coverage Report for Build 7302146633Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
|
Thank you @szepeviktor and @localheinz |
|
Glad to contribute. |
This may help future contributors.