Improve wording in README #915
Conversation
There was a problem hiding this comment.
Hi @szepeviktor,
thanks for the improvements and sorry for the late response (I was on GitHub detox 😁).
Generally changes to docs must be made via the code (fixer's descriptions and ReadmeCommand and then running php .dev-tools/generate_readme.php > README.md, or simply composer fix), but the pipeline is failing anyway (due to changes in the Fixer's repo), so I will merge this one and make a follow up with changes in code to match README.
However, that will revert the descriptions of DataProvider* as they took the description from the Fixer repo: https://github.com/kubawerlos/php-cs-fixer-custom-fixers/blob/v3.16.2/src/Fixer/DataProviderNameFixer.php#L46
Would you like to create a PR there (similar flow - changing description in code and running ./dev-tools/doc is needed) or do you want me to do it?
| @@ -318,7 +318,7 @@ Configuration options: | |||
| ``` | |||
|
|
|||
| #### NoTrailingCommaInSinglelineFixer | |||
| Trailing comma in the list on the same line as the end of the block must be removed. | |||
| There must be no trailing comma in arrays written on one line. | |||
There was a problem hiding this comment.
This fixer changes foo(1, 2, ); and list($x, $y) = $list; too.
I would like you to create that PR. |
@kubawerlos This is all my English knowledge.