[patch] Fix sRGB/linear color-space slips in ThemeProvider#43
Merged
Conversation
- Demo AdjustBrightness multiplied gamma-encoded sRGB channels; a multiplicative brightness change is a linear-light operation, so scale the linear channels via Color.FromLinear instead. - Demo ToImVec4 hardcoded alpha=1.0 and dropped color.A; preserve the color's alpha while still allowing an explicit override. - ColorRange.IsSingleColor compared the Oklab distance against double.Epsilon (effectively exact equality); use a small perceptual threshold (1e-6) matching the "single color" intent. - Collapse a dead no-op ternary in SemanticColorMapper.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Low-severity color-space fixes found in a linear/sRGB audit. The core library pipeline was already space-clean; these are the edge slips.
ThemeProviderDemo/Program.cs—AdjustBrightness: multiplied gamma-encoded sRGB channels by a factor. Multiplicative brightness is a linear-light operation, so it now scales the linear channels viaColor.FromLinear, giving a perceptually correct result.ThemeProviderDemo/Program.cs—ToImVec4: hardcodedalpha = 1.0and discardedcolor.A. Now preserves the color's alpha (alpha ?? (float)color.A) while still allowing an explicit override.ThemeProvider/ColorRange.cs—IsSingleColor: compared the Oklab distance againstdouble.Epsilon(~4.9e-324, effectively exact equality), contradicting the "single color" intent. Now uses a named1e-6perceptual threshold.ThemeProvider/SemanticColorMapper.cs: collapsed a deadmeaning == Neutral ? globalCenter : globalCenterno-op ternary.Verification
ThemeProvider.slnbuilds with 0 warnings / 0 errors (warnings-as-errors).ThemeProvider.Testpasses (roundtrip, accessibility, semantic-mapper suites).🤖 Generated with Claude Code