Bump the ktsu ImGui suite to 3.32.0 - #42
Open
matt-edmondson wants to merge 1 commit into
Open
Conversation
Picks up the recentring pass, which is what a graph editor sees most directly: a settled document now sits centred on the origin instead of somewhere off to one side of it. Gravity could not do that job. It pulls every body the same amount whichever side of the target it sits, so summed over a graph it counts bodies rather than measuring them and is exactly zero anywhere the counts balance — a dead band rather than an equilibrium. Placement is now a separate pass that slides the whole arrangement, which cannot change any distance between bodies and so leaves the layout itself alone. Measured over the corpus, mean offset from the origin fell from 62.7 units to 5.4. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018b2bn5CKSzpjRV4nxv3c3y
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the recentring pass from ktsu-dev/ImGuiApp#383. All seven ktsu ImGui-suite pins go 3.31.0 → 3.32.0.
What changes for the editor
A settled document now sits centred on the world origin instead of somewhere off to one side of it.
Gravity could not do that job. It pulls every body the same amount whichever side of the target it sits, so summed over a graph it counts bodies rather than measuring them, and is exactly zero anywhere the counts balance — a dead band rather than an equilibrium. A twelve-node chain settled 79 units one side and stayed; shoved 600 the other way it came to rest 79 units to the other side. Placement is now a separate pass that slides the whole arrangement, which cannot change any distance between bodies and so leaves the layout itself untouched.
Measured in this repo's own editor, on the sample function after 300 frames:
The origin is
graphSize * 0.5wheregraphSizeis the canvas less the 280px inspector column, so 360 horizontally and 300 vertically — the graph now lands on it to within a fifth of a unit on both axes.Testing
dotnet restore,dotnet build -c Release(0 warnings, 0 errors), full suite 378/378.Editor_KeepsTheLayoutInsideTheViewandEditor_CentresTheDocumentOnTheFirstFrameboth pass unchanged — no threshold needed adjusting this time, which is the outcome the centre assertion added in #40 was meant to produce.One note for future bumps:
ktsu.ImGui.Styleris a transitive dependency of the suite and propagates to NuGet on its own schedule, so a restore can fail with NU1102 for it after every pinned package is already live. Retrying the restore is the reliable check; enumerating pinned packages is not.🤖 Generated with Claude Code
https://claude.ai/code/session_018b2bn5CKSzpjRV4nxv3c3y
Generated by Claude Code