Bump the ktsu ImGui suite to 3.27.0 - #38
Merged
Merged
Conversation
Picks up the change to how the force-directed layout measures repulsion: it is now measured across the clear space between two node bounding boxes rather than between their centres, so the same setting leaves the same room between a pair of literals as between a pair of classes instead of crowding the big nodes and marooning the small ones (ktsu-dev/ImGuiApp#371). Nothing in Coder needs changing with it. The graph editor takes its physics from the engine's defaults and the shared PhysicsSettingsPanel rather than hard-coding any tuned value, so the recalibrated RepulsionStrength - halved from 1,200,000 to 600,000, because the distance being measured is now the smaller number - flows through on its own. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018b2bn5CKSzpjRV4nxv3c3y
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the six ktsu ImGuiApp-suite pins in
Directory.Packages.propsfrom 3.26.0 to 3.27.0:ktsu.ImGui.App,ktsu.ImGui.App.Testing,ktsu.ImGui.SyntaxHighlighting,ktsu.ImGui.Widgets,ktsu.ImGui.NodeEditor,ktsu.ForceDirectedLayout.What this picks up
3.27.0 carries ktsu-dev/ImGuiApp#375, which changes how the force-directed layout measures repulsion. It was measured between body centres, which counts each node's own extent as part of the distance between them — so a node pressed against the side of a wide one still had distant centres and nothing pushed back, while two small nodes with a screen of space between them read as crowded. It is now measured across the clear space between the two bounding boxes, so the same setting leaves the same room whatever size the nodes are.
Because the measured distance is now the smaller number,
RepulsionStrength's default was recalibrated from 1,200,000 to 600,000 upstream. Over ten starting arrangements of a twenty-node document that leaves the settled graph the size it was, with the same edge angle and the same number of links drawn over bodies, while the tightest pair goes from 22 units of clear space to 69.Nothing else to change here
Coder hard-codes no physics values —
AstGraphusesEngine.PhysicsSettings with { Enabled = true }andAstGraphEditordraws the sharedPhysicsSettingsPanel— so the recalibrated default flows through on its own. I checked for any tunedRepulsionStrengththat would have needed halving alongside it; there is none.Verification
dotnet build -c Releaseclean, no warnings.Coder.Test373/373 passing against 3.27.0.🤖 Generated with Claude Code
https://claude.ai/code/session_018b2bn5CKSzpjRV4nxv3c3y
Generated by Claude Code