Skip to content

Conversation

osipxd
Copy link
Member

@osipxd osipxd commented Sep 19, 2025

Subsystem
Core

Motivation
KTOR-8901 Remove AnnotationTarget.FUNCTION from @KtorDsl

Solution
This PR removes wrongly applied annotations and removes the annotation target FUNCTION.

I'd merge this into the next patch release, however this change might break code misusing the @KtorDsl annotation. The main point why I want it to be included is that this change prevents further misuse of the @KtorDsl annotation.

@osipxd osipxd requested a review from bjhham September 19, 2025 11:18
@osipxd osipxd self-assigned this Sep 19, 2025
Copy link
Contributor

coderabbitai bot commented Sep 19, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch osipxd/ktordsl-remove-function-target

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@bjhham bjhham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd merge this into the next patch release, however this change might break code misusing the @KtorDsl annotation. The main point why I want it to be included is that this change prevents further misuse of the @KtorDsl annotation.

It sounds like you meant to select main for the base branch in this case...

@osipxd
Copy link
Member Author

osipxd commented Sep 19, 2025

We could merge all changes except for removing the target into the patch release 🤔
And merge removing the target into the main.

@osipxd osipxd force-pushed the osipxd/ktordsl-remove-function-target branch from 7f73c21 to da85cfb Compare September 19, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants