Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added circle circle intersection area #139

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added circle circle intersection area #139

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed27477
Added circle circle intersection area
Chillee Nov 3, 2019
5952d3e
Responded to comments
Chillee Nov 4, 2019
49b7914
responded to comments
Chillee Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions content/geometry/CircleCircleArea.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/**
* Author: Takanori MAEHARA, chilli
* Date: 2019-11-03
* License: CC0
* Source: https://github.com/spaghetti-source/algorithm/blob/master/geometry/_geom.cc#L729
* Description: Calculates the area of the intersection of 2 circles
* Status:
*/

template<class P>
double circleCircleArea(P c, double cr, P d, double dr) {
if (cr < dr) swap(c, d), swap(cr, dr);
Chillee marked this conversation as resolved.
Show resolved Hide resolved
auto A = [&](double r, double h) {
return r*r*acos(h/r)-h*sqrt(r*r-h*h);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the epsilons now means that r < h can happen due to numerical precision, I suspect (though I haven't tested). h = min(h, r); may be reasonable? h < 0 can likely also happen but doesn't seem like a problem.

};
auto l = (c - d).dist(), a = (l*l + cr*cr - dr*dr)/(2*l);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double is clearer than auto

if (l - cr - dr >= 0) return 0; // far away
if (l - cr + dr <= 0) return M_PI*dr*dr;
if (l - cr >= 0) return A(cr, a) + A(dr, l-a);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these inequalities can be simplified now without the epsilons

else return A(cr, a) + M_PI*dr*dr - A(dr, a-l);
}
Chillee marked this conversation as resolved.
Show resolved Hide resolved