Change class names

README.md

@@ -20,14 +20,14 @@ $ composer require ksdev/nbp-currency-converter
 
 ``` php
 use Ksdev\NBPCurrencyConverter\CurrencyConverter;
-use Ksdev\NBPCurrencyConverter\ExRatesDayTableFinder;
-use Ksdev\NBPCurrencyConverter\ExRatesDayTableFactory;
+use Ksdev\NBPCurrencyConverter\ExRatesTableFinder;
+use Ksdev\NBPCurrencyConverter\ExRatesTableFactory;
 use GuzzleHttp\Client;
 
 $converter = new CurrencyConverter(
-    new ExRatesDayTableFinder(
+    new ExRatesTableFinder(
         new Client(),
-        new ExRatesDayTableFactory(),
+        new ExRatesTableFactory(),
         'path/to/cache/folder'
     )
 );

src/CurrencyConverter.php

@@ -6,7 +6,7 @@ class CurrencyConverter
 {
     private $ratesTableFinder;
 
-    public function __construct(ExRatesDayTableFinder $ratesTableFinder)
+    public function __construct(ExRatesTableFinder $ratesTableFinder)
     {
         $this->ratesTableFinder = $ratesTableFinder;
     }
@@ -22,7 +22,7 @@ public function __construct(ExRatesDayTableFinder $ratesTableFinder)
      */
     public function averageExchangeRates(\DateTime $pubDate = null)
     {
-        $ratesTable = $this->ratesTableFinder->getExRatesDayTable($pubDate);
+        $ratesTable = $this->ratesTableFinder->getExRatesTable($pubDate);
         return $ratesTable->parsedContent;
     }
 

src/ExRatesDayTable.php → src/ExRatesTable.php

@@ -2,7 +2,7 @@
 
 namespace Ksdev\NBPCurrencyConverter;
 
-class ExRatesDayTable
+class ExRatesTable
 {
     /** @var string */
     public $rawContent;

src/ExRatesDayTableFactory.php → src/ExRatesTableFactory.php

@@ -2,17 +2,17 @@
 
 namespace Ksdev\NBPCurrencyConverter;
 
-class ExRatesDayTableFactory
+class ExRatesTableFactory
 {
     /**
-     * Get new ExRatesDayTable
+     * Get new ExRatesTable
      *
      * @param string $rawContent Raw xml content
      *
-     * @return ExRatesDayTable
+     * @return ExRatesTable
      */
     public function getInstance($rawContent)
     {
-        return new ExRatesDayTable($rawContent);
+        return new ExRatesTable($rawContent);
     }
 }

src/ExRatesDayTableFinder.php → src/ExRatesTableFinder.php

@@ -2,15 +2,15 @@
 
 namespace Ksdev\NBPCurrencyConverter;
 
-class ExRatesDayTableFinder
+class ExRatesTableFinder
 {
     const NBP_XML_URL = 'http://www.nbp.pl/kursy/xml/';
     const MAX_ONE_TIME_API_REQ = 7;
 
     /** @var \GuzzleHttp\Client */
     private $guzzle;
 
-    /** @var ExRatesDayTableFactory */
+    /** @var ExRatesTableFactory */
     private $ratesTableFactory;
 
     /** @var string */
@@ -21,14 +21,14 @@ class ExRatesDayTableFinder
 
     /**
      * @param \GuzzleHttp\Client $guzzle
-     * @param ExRatesDayTableFactory $ratesTableFactory
+     * @param ExRatesTableFactory $ratesTableFactory
      * @param string $cachePath Optional path to an existing folder where the cache files will be stored
      *
      * @throws \Exception
      */
     public function __construct(
         \GuzzleHttp\Client $guzzle,
-        ExRatesDayTableFactory $ratesTableFactory,
+        ExRatesTableFactory $ratesTableFactory,
         $cachePath = ''
     ) {
         $this->guzzle = $guzzle;
@@ -42,15 +42,15 @@ public function __construct(
     }
 
     /**
-     * Get the ExRatesDayTable instance
+     * Get the ExRatesTable instance
      *
      * @param \DateTime $pubDate Optional rates table publication date
      *
-     * @return ExRatesDayTable
+     * @return ExRatesTable
      *
      * @throws \Exception
      */
-    public function getExRatesDayTable(\DateTime $pubDate = null)
+    public function getExRatesTable(\DateTime $pubDate = null)
     {
         $this->setSoughtPubDate($pubDate);
 

tests/CurrencyConverterTest.php

@@ -3,8 +3,8 @@
 namespace Ksdev\NBPCurrencyConverter\Test;
 
 use Ksdev\NBPCurrencyConverter\CurrencyConverter;
-use Ksdev\NBPCurrencyConverter\ExRatesDayTableFactory;
-use Ksdev\NBPCurrencyConverter\ExRatesDayTableFinder;
+use Ksdev\NBPCurrencyConverter\ExRatesTableFactory;
+use Ksdev\NBPCurrencyConverter\ExRatesTableFinder;
 use Mockery;
 
 class CurrencyConverterTest extends \PHPUnit_Framework_TestCase
@@ -39,7 +39,7 @@ public function guzzleMock()
 
     public function testConvert()
     {
-        $converter = new CurrencyConverter(new ExRatesDayTableFinder($this->guzzleMock(), new ExRatesDayTableFactory()));
+        $converter = new CurrencyConverter(new ExRatesTableFinder($this->guzzleMock(), new ExRatesTableFactory()));
         $pubDate = new \DateTime('2015-07-03');
 
         $this->assertEquals('0.2651', $converter->convert('1.0000', 'PLN', 'USD', $pubDate)['amount']);
@@ -64,7 +64,7 @@ public function testConvert()
 
     public function testInvalidPublicationDate()
     {
-        $converter = new CurrencyConverter(new ExRatesDayTableFinder($this->guzzleMock(), new ExRatesDayTableFactory()));
+        $converter = new CurrencyConverter(new ExRatesTableFinder($this->guzzleMock(), new ExRatesTableFactory()));
 
         $numExceptions = 0;
         try {
@@ -87,7 +87,7 @@ public function testInvalidPublicationDate()
 
     public function testInvalidFormatOfAmount()
     {
-        $converter = new CurrencyConverter(new ExRatesDayTableFinder($this->guzzleMock(), new ExRatesDayTableFactory()));
+        $converter = new CurrencyConverter(new ExRatesTableFinder($this->guzzleMock(), new ExRatesTableFactory()));
         $pubDate = new \DateTime('2015-07-03');
 
         $numExceptions = 0;
@@ -125,7 +125,7 @@ public function testInvalidFormatOfAmount()
      */
     public function testInvalidCurrencyCode()
     {
-        $converter = new CurrencyConverter(new ExRatesDayTableFinder($this->guzzleMock(), new ExRatesDayTableFactory()));
+        $converter = new CurrencyConverter(new ExRatesTableFinder($this->guzzleMock(), new ExRatesTableFactory()));
         $pubDate = new \DateTime('2015-07-03');
 
         $converter->convert('123.4567', 'ABC', 'USD', $pubDate);
@@ -137,7 +137,7 @@ public function testInvalidCurrencyCode()
      */
     public function testInvalidCachePath()
     {
-        new CurrencyConverter(new ExRatesDayTableFinder($this->guzzleMock(), new ExRatesDayTableFactory(), '/this/folder/doesnotexist'));
+        new CurrencyConverter(new ExRatesTableFinder($this->guzzleMock(), new ExRatesTableFactory(), '/this/folder/doesnotexist'));
     }
 
     /**
@@ -168,7 +168,7 @@ public function testInvalidXml()
             ->andReturn($dirMock)
             ->mock();
 
-        $converter = new CurrencyConverter(new ExRatesDayTableFinder($guzzleMock, new ExRatesDayTableFactory()));
+        $converter = new CurrencyConverter(new ExRatesTableFinder($guzzleMock, new ExRatesTableFactory()));
         $pubDate = new \DateTime('2015-07-03');
         $converter->convert('123.4567', 'PLN', 'USD', $pubDate);
     }
@@ -188,7 +188,7 @@ public function testInvalidResponseStatusCode()
             ->andReturn('A good reason')
             ->mock();
 
-        $converter = new CurrencyConverter(new ExRatesDayTableFinder($guzzleMock, new ExRatesDayTableFactory()));
+        $converter = new CurrencyConverter(new ExRatesTableFinder($guzzleMock, new ExRatesTableFactory()));
         $converter->convert('123.4567', 'PLN', 'USD');
     }
 
@@ -223,7 +223,7 @@ public function testCache()
             ->andReturn($dirMock)
             ->mock();
 
-        $converter = new CurrencyConverter(new ExRatesDayTableFinder($guzzleMock, new ExRatesDayTableFactory(), __DIR__));
+        $converter = new CurrencyConverter(new ExRatesTableFinder($guzzleMock, new ExRatesTableFactory(), __DIR__));
         $pubDate = new \DateTime('2015-07-03');
         $converter->convert('123.4567', 'PLN', 'USD', $pubDate);