This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix the warnings produced by nightly #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
env::home_dir is deprecated, and there were also some unused imports. I noticed this when building from the AUR. I can't fully test this because I'm getting some weird link errors (before my changes too), but there are no longer any warnings. I introduced the dependency "dirs" to "krd_client", which is now the recommended way of getting the home directory PathBuf.
|
What link errors are you seeing? I'd like to fix those as well |
|
Here they are (a bit gross): However it compiles fine when I use the AUR package, so I'm assuming I'm missing a dependency somewhere. I do have emscripten installed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
env::home_dir is deprecated, and there were also some unused imports. I
noticed this when building from the AUR.
I can't fully test this because I'm getting some weird link errors
(before my changes too), but there are no longer any warnings.
I introduced the dependency "dirs" to "krd_client", which is now the
recommended way of getting the home directory PathBuf.