-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get HPO working again #141
Conversation
dinogun
commented
Jan 9, 2025
- Use EmailMessage as cgi is deprecated
- Dockerfile should use python3 instead of python39
- Add missing source script
- Updated OS image
- Use quay.io repo instead of DockerHub
1. Updated OS image 2. Use quay.io repo instead of DockerHub Signed-off-by: Dinakar Guniguntala <[email protected]>
Signed-off-by: Dinakar Guniguntala <[email protected]>
@dinogun I see scripts |
Works as expected across all environments. Tested on native,docker,openshift. |
There are some future warnings with HPO related to tunables. It would be good to address them as well later to prevent potential issues down the line.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@bharathappali Reg fastapi, we can do those as a separate PR if needed. Right now just want to fix what is broken |
I completely agree, Will raise an issue to keep track of it. Thanks @dinogun |