changed Up metrics to look for just Success response #1340
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kruize checks if the datasource is reachable by querying the following metric:
http://127.0.0.1:9090/api/v1/query?query=up.
Prometheus/Thanos typically returns the current status of the targets (such as services or jobs) it monitors. However, in this case, Thanos was unable to provide those details, even though the response status was 200 OK.
Kruize only needs to confirm that the response is 200 OK to proceed, and currently, it's not concerned with the actual content of the response. Therefore, the fix will focus on simply checking for a 200 OK status and moving forward based on that
{ "status": "success", "data": { "resultType": "vector", "result": [ { "metric": { "__name__": "up", "instance": "localhost:9090", "job": "prometheus" }, "value": [1696841450.278, "1"] }, { "metric": { "__name__": "up", "instance": "localhost:9100", "job": "node" }, "value": [1696841450.278, "1"] } ] } }
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here