Add MetricProfile In-Memory Storage Collection #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyabiradar07
added
enhancement
| metricProfileCollection.put(metricProfileName, metricProfile); | ||
| } | ||
| } | ||
| } |
| public void setSlo(JsonNode slo) { | ||
| this.slo = slo; | ||
| } | ||
| } |
| } | ||
| response.sendError(httpStatusCode, errorMsg); | ||
| } | ||
| } |
msvinaykumar
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Review Checklist
Common Review
- Code formatting adheres to the project’s style guide.
- No unnecessary commented-out code.
- Appropriate use of comments and documentation.
Logical Flow Review
- Code logic is clear and easy to follow.
- All branches and conditions are covered and tested.
- No redundant or duplicate code.
Demo Update
- Demonstration examples are updated to reflect changes.
- README and documentation include updated demo instructions.
- Any necessary demo files are included and tested.
Naming Conventions
- Variable and function names follow the project's naming conventions.
- File names are descriptive and adhere to naming standards.
- No ambiguous or misleading names.
Workflow
- CI/CD pipelines are updated and passing.
- Tests are included and all pass.
- The workflow for deploying or integrating changes is clear and documented.
Does It Affect ROS
- Changes are reviewed for compatibility with ROS.
- ROS-specific configurations are updated if necessary.
- Any ROS dependencies or integrations are tested and verified.
|
LGTM |
msvinaykumar
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Review Checklist
Common Review
- Code formatting adheres to the project’s style guide.
- No unnecessary commented-out code.
- Appropriate use of comments and documentation.
Logical Flow Review
- Code logic is clear and easy to follow.
- All branches and conditions are covered and tested.
- No redundant or duplicate code.
Demo Update
- Demonstration examples are updated to reflect changes.
- README and documentation include updated demo instructions.
- Any necessary demo files are included and tested.
Naming Conventions
- Variable and function names follow the project's naming conventions.
- File names are descriptive and adhere to naming standards.
- No ambiguous or misleading names.
Workflow
- CI/CD pipelines are updated and passing.
- Tests are included and all pass.
- The workflow for deploying or integrating changes is clear and documented.
Does It Affect ROS
- Changes are reviewed for compatibility with ROS.
- ROS-specific configurations are updated if necessary.
- Any ROS dependencies or integrations are tested and verified.
|
LGTM |
shreyabiradar07
force-pushed
the
metric-profile-collection
branch
from
7b8be02
to
8d8d456
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements in-memory storage of
MetricProfileduring Autotune initialization and after creating a new metric profileNOTE: this PR is created on top of #1258 and has a dependency to be merged first
Type of change
How has this been tested?
Tested using local_monitoring demo script
Test Configuration
Checklist 🎯
Additional information
.