next update #19
Merged
next update #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
krowinski
commented
Nov 26, 2016
krowinski
commented
- Documentation update
- MySQLRepository and BinLogSocketConnect extract to interfaces
- BinLogSocketConnect exception set as const
- register slave use now hostname and port to be correct display in "SHOW SLAVE HOSTS"
- dbname removed from configuration as is no more in use
- added foreign keys info to events
|
Hi, The original query for foreign keys information from this commit: b3k@d390cc0 is quite faster (30-50x, tested on database with ~ 1200 tables). It's a little bit more complicated, but it's worth from performance POV. I suggest to change it to original form with subquery. P.S. It would be nice next time to ask for pull request, not to copy the code. We're in the middle of developing and deploying our own tool and this is why we didn't try to merge it right now. Thx |
krowinski
added a commit
that referenced
this pull request
Jul 12, 2017
* Documentation update * MySQLRepository and BinLogSocketConnect extract to interfaces * BinLogSocketConnect exception set as const * register slave use now hostname and port to be correct display in "SHOW SLAVE HOSTS" * dbname removed from configuration as is no more in use * added foreign keys info to events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.