Skip to content

feat: added more versions to check#121

Open
krowinski wants to merge 11 commits intomasterfrom
feature/more-tests
Open

feat: added more versions to check#121
krowinski wants to merge 11 commits intomasterfrom
feature/more-tests

Conversation

@krowinski
Copy link
Owner

No description provided.

@DZunke
Copy link
Contributor

DZunke commented May 15, 2024

Nice shot! 🚀

@krowinski
Copy link
Owner Author

krowinski commented Jun 12, 2024

hmm its not working 🤔

https://github.com/krowinski/php-mysql-replication/actions/runs/9480998905/job/26122839257

all pass

............................................................... 63 / 130 ( 48%) ............................................................... 126 / 130 ( 96%) .... 130 / 130 (100%)
but in code

if ($this->checkForVersion(5.7) || $this->mySQLReplicationFactory?->getServerInfo()->isMariaDb()) { self::markTestIncomplete('Only for mysql 5.7 or higher'); }

so it's should skip 🤔

@cgrabenstein
Copy link
Contributor

@krowinski I took a stab at this because setting this up apparently blocks other PRs. Please have a look at my attempt (#136). Also my PR uncovered an incompatibility with mysql 8.4 which I also fixed in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments