use downstream packages #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CtrlZmaster
force-pushed
the
use-downstream-pycrypto
branch
2 times, most recently
from
66d0248
to
f2c76c4
Compare
CtrlZmaster
force-pushed
the
use-downstream-pycrypto
branch
from
f2c76c4
to
37afbde
Compare
Cryptography is currently broken upstream due to deprecation of OpenSSL engines in Fedora 41+ and CentOS Stream 10. I managed to merge a fix upstream, but it will take some time until they release a new version. For more details, see the GitHub issue: pyca/cryptography#11690 Before this commit, some packages were installed from pip. This is not desired, pcs dependencies are given as rpm packages, not python packages. Presumably, even upstream users use downstream packages if they build pcs. Downstream packages have an advantage of being tuned for the distribution, which can resolve the kinds of issues as cryptography has now. Additionally, the pip installed packages were not the ones that can be bundled by autotools, so pcs is still tested with the newest possible bundled dependencies. Some context for not having --system-site-packages from Fabio: it was to stress the build system in different ways one env might have python3-foo installed, another doesn't causing different results say today: we test pcs build X and it works tomorrow some other packages pulls in python3-something that goes from embedded to system and then pcs starts to fail it creates a rather unpredictable build env on rhel8 we could use system stuff, and we needed it IIRC others can have all embedded
CtrlZmaster
force-pushed
the
use-downstream-pycrypto
branch
from
37afbde
to
8d631db
Compare
|
This PR also fixes problems caused by installing Python packages from upstream that were pulling new setuptools that do not use their bundled dependencies but pull incompatible versions from the system. These are the CI results with this patch:
@fabbione, please, merge this and switch pcs pipelines back to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chrissie-c, please, test this in cc-devel. I have the ClusterLabs/pcs#864 open for testing, but let me first push a commit to disable the tests that are failing due to pacemaker before testing this, I'll let you know.
Cryptography is currently broken upstream due to deprecation of OpenSSL engines in Fedora 41+ and CentOS Stream 10. I managed to merge a fix upstream, but that will take some time until they release a new version. For more details, see the GitHub issue:
pyca/cryptography#11690