Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving documentation for quickstart #14

Open
wants to merge 1 commit into
base: helmcharts
Choose a base branch
from

Conversation

firemanxbr
Copy link

After testing release 0.3.0, I'm sharing some improvements to help other users test the Kubeflow Helm Charts.

Copy link
Owner

@kromanow94 kromanow94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you :)


## Requirements
* kind v0.25.0 or above
* helm v3.16.3 or above
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v3.16.3 is just 3 weeks old. I'm using v3.15.4 on my local machine and it works fine. Maybe we can write "tested on v3.15.4 but should work with older versions as well"?

This guide was created to help new users of Kubeflow install and test Kubeflow Helm Charts locally based on the kind.

## Requirements
* kind v0.25.0 or above
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.25.0 is just a month old, we could definitely run on an older version. Maybe we can write "tested on v0.25.0 but should work with older versions as well"?

## Requirements
* kind v0.25.0 or above
* helm v3.16.3 or above
* curl 8.7.1 or above
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need any specific feature of curl. Maybe we can write that just the curl itself is required for quickstart?

@@ -0,0 +1,45 @@
# Kind
This guide was created to help new users of Kubeflow install and test Kubeflow Helm Charts locally based on the kind.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We provide multiple quickstart scripts, I think it would be much better to explain all of the quickstarts. Is this something you could add?

Some other resources you might find helpful in describing other quickstarts:

$ helm repo update
```

## Install
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we could provide explanation of different quickstart options.

@kromanow94
Copy link
Owner

Hey, as mentioned in the #13 (comment), could you also update the README.md file so it's easier to explain the quickstarts or at least link them there?

Also, the README.md is an unmodified file from the kubeflow/manifests repository. It would be great to make a proper README for this repository and the Helm Chart. Is this something you could also do on your end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants