docs: add zkVM fault proof #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sm-stack
force-pushed
the
feat/add-zkvm-fault-proof
branch
from
d93b900 to
e74449b
Compare
Pangssu
reviewed
Dec 2, 2024
specs/protocol/predeploys.md
Outdated
Comment on lines
50
to
52
| | ProtocolVault | 0x4200000000000000000000000000000000000006 | Bedrock | Yes | Yes | | ||
| | L1FeeVault (*deprecated*) | 0x4200000000000000000000000000000000000007 | Bedrock | Yes | Yes | | ||
| | ValidatorRewardVault | 0x4200000000000000000000000000000000000008 | Bedrock | Yes | Yes | |
There was a problem hiding this comment.
Since "deprecated" is mentioned in the detail description below, it would be better to mark it here as well.
Suggested change
| | ProtocolVault | 0x4200000000000000000000000000000000000006 | Bedrock | Yes | Yes | | |
| | L1FeeVault (*deprecated*) | 0x4200000000000000000000000000000000000007 | Bedrock | Yes | Yes | | |
| | ValidatorRewardVault | 0x4200000000000000000000000000000000000008 | Bedrock | Yes | Yes | | |
| | ProtocolVault (*deprecated*) | 0x4200000000000000000000000000000000000006 | Bedrock | Yes | Yes | | |
| | L1FeeVault (*deprecated*) | 0x4200000000000000000000000000000000000007 | Bedrock | Yes | Yes | | |
| | ValidatorRewardVault (*deprecated*) | 0x4200000000000000000000000000000000000008 | Bedrock | Yes | Yes | |
specs/zk-fault-proof/challenge.md
Outdated
| @@ -440,5 +376,4 @@ Colosseum contract should be deployed behind upgradable proxies. | |||
| | `BISECTION_TIMEOUT` | 3600 | seconds | | |||
| | `PROVING_TIMEOUT` | 28800 | seconds | | |||
| | `SEGMENTS_LENGTHS` | [9, 6, 10, 6] | array of integers | | |||
| | `MAX_TXS` | 100 | uint256 | | |||
| | `DUMMY_HASH` | 0xedf1ae3da135c124658e215a9bf53477facb442a1dcd5a92388332cb6193237f | bytes32 | | |||
There was a problem hiding this comment.
Is a DUMMY_HASH still necessary?
There was a problem hiding this comment.
No, I'll delete it. Thanks!
Pangssu
approved these changes
Dec 2, 2024
seolaoh
reviewed
Dec 4, 2024
seolaoh
reviewed
Dec 6, 2024
seolaoh
approved these changes
Dec 6, 2024
0xbenyun
reviewed
Dec 10, 2024
specs/glossary.md
Outdated
| @@ -349,7 +341,7 @@ A trusted validator is an actor who is run by Lightscale. If validations are not | |||
|
|
|||
| [validating-epoch]: glossary.md#validating-epoch | |||
|
|
|||
| c of [L2] [blocks][block] where needs to be checkpointed. | |||
| Number of [L2][L2] [blocks][block] where needs to be checkpointed. | |||
There was a problem hiding this comment.
How about this?
Suggested change
| Number of [L2][L2] [blocks][block] where needs to be checkpointed. | |
| The number of [L2][L2] [blocks][block] that need to be checkpointed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added zkVM fault proof section at zk-fault-proof section. This inquires changes/addition such as:
next_block_hash.Also reflected changes that we have made or will make, such as:
ValidatorRewardScalarand changes on fee distribution.One more PR regarding the MPT migration fork (based on spec section) will be followed.