Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spec of mint manager #1

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

Pangssu
Copy link
Contributor

@Pangssu Pangssu commented Mar 14, 2024

No description provided.

@Pangssu Pangssu requested a review from a team March 14, 2024 10:52
@Pangssu Pangssu force-pushed the feat/add-spec-of-mint-manager branch 2 times, most recently from 3432867 to 097b4b5 Compare March 14, 2024 11:01
@Pangssu Pangssu marked this pull request as draft March 20, 2024 16:39
@Pangssu Pangssu force-pushed the feat/add-spec-of-mint-manager branch from 097b4b5 to bc36900 Compare March 27, 2024 07:38
@Pangssu Pangssu marked this pull request as ready for review March 27, 2024 07:38
@Pangssu Pangssu force-pushed the feat/add-spec-of-mint-manager branch 2 times, most recently from c4dc221 to dc0b97f Compare March 27, 2024 07:41
@Pangssu Pangssu force-pushed the feat/add-spec-of-mint-manager branch from dc0b97f to 75d8a92 Compare March 27, 2024 07:43
@0xHansLee
Copy link
Contributor

Please rebase to the main first

Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sm-stack sm-stack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a nit

specs/protocol/mint-manager.md Outdated Show resolved Hide resolved
Co-authored-by: Harry | Seungmin Jeon <[email protected]>
@Pangssu Pangssu merged commit 941efe6 into main Apr 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants