Skip to content

Commit

Permalink
docs: apply PR reviews
Browse files Browse the repository at this point in the history
  • Loading branch information
sm-stack committed Dec 6, 2024
1 parent 3fc7dd4 commit f969656
Show file tree
Hide file tree
Showing 5 changed files with 60 additions and 8 deletions.
6 changes: 3 additions & 3 deletions specs/protocol/ecotone/l1-attributes.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,14 @@ The `overhead` and `scalar` values can continue to be accessed after the Ecotone
but no longer have any effect on system operation. These fields were also known as the `l1FeeOverhead`
and the `l1FeeScalar`.

After running `pnpm build` in the `packages/contracts-bedrock` directory, the bytecode to add to
After running `pnpm build` in the `packages/contracts` directory, the bytecode to add to
the genesis file will be located in the `deployedBytecode` field of the build artifacts file at
`/packages/contracts-bedrock/forge-artifacts/L1Block.sol/L1Block.json`.
`/packages/contracts/forge-artifacts/L1Block.sol/L1Block.json`.

### Ecotone L1Block upgrade

The L1 Attributes Predeployed contract, `L1Block.sol`, is upgraded as part of the Ecotone upgrade.
The version is incremented to `1.2.0`, one new storage slot is introduced, and one existing slot
The version is incremented to `1.1.0`, one new storage slot is introduced, and one existing slot
begins to store additional data:

- `blobBaseFee` (`uint256`): The L1 blob base fee.
Expand Down
4 changes: 2 additions & 2 deletions specs/protocol/mpt-migration/exec-engine.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ rules are applied when the `L2 Timestamp >= activation time`.
Since the underlying trie structure is changed from the ZK Trie to the Merkle Patricia Trie, the historical RPC is used
for the RPC calls that are related to the historical data before the Kroma MPT Migration upgrade. The historical RPC
provides the historical data that is stored in the ZK Trie. The following endpoints will route the call to the
historical RPC if the requested timestamp is before the activation time of the Kroma MPT Migration upgrade:
historical RPC if the requested block timestamp is before the activation time of the Kroma MPT Migration upgrade:

### `eth_` namespace

Expand Down Expand Up @@ -80,7 +80,7 @@ with vanilla OP Stack, the `isSystemTransaction` boolean is re-enabled.
However, since `isSystemTransaction` was disabled as in the [Regolith upgrade](../regolith/overview.md), system
transactions remain to use the same gas accounting rules as regular deposits.

## Fee Distribution Process
### Fee Distribution Process

The fee distribution process is updated to be compatible with OP Stack. Previously, the fee distribution process was
defined to support robustness of validator system.
Expand Down
10 changes: 7 additions & 3 deletions specs/protocol/mpt-migration/overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
## Execution Layer

- [Transition from ZK Trie to MPT](./exec-engine.md#transition-from-zk-trie-to-mpt)
- [`SELFDESTRUCT` opcode](./exec-engine.md#selfdestruct-opcode)
- [`isSystemTransaction` boolean at transaction struct](./exec-engine.md#issystemtransaction-boolean)
- [Fee distribution process](./exec-engine.md#fee-distribution-process)
- [Enable `SELFDESTRUCT` opcode](./exec-engine.md#selfdestruct-opcode)
- [Revive `isSystemTransaction` field at `DepositTx`](./exec-engine.md#issystemtransaction-boolean)
- [Modify Fee distribution process](./exec-engine.md#fee-distribution-process)

## Smart Contracts

- [Change Predeploys addresses](./predeploys.md)
46 changes: 46 additions & 0 deletions specs/protocol/mpt-migration/predeploys.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
# Predeploys

<!-- START doctoc generated TOC please keep comment here to allow auto update -->
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
**Table of Contents**

- [GasPriceOracle](#gaspriceoracle)
- [L1 Gas Usage Estimation](#l1-gas-usage-estimation)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

## Changes on Predeploys

### L1Block

Following the Kroma MPT upgrade, the calldata to set values in the `L1Block` predeploy is updated to
exclude the `validatorRewardScalar`. Now the calldata is as follows:

```
baseFeeScalar ++ blobBaseFeeScalar ++ sequenceNumber ++ timestamp ++ blockNumber ++ baseFee ++ blobBaseFee ++ blockHash ++ batcherHash
```

Also, the address of `L1Block` is changed from `0x4200000000000000000000000000000000000002` to
`0x4200000000000000000000000000000000000015`. The original address is now deprecated and not used after the Kroma MPT
hard fork.

### L1FeeVault

The address of `L1FeeVault` is changed from `0x4200000000000000000000000000000000000007` to
`0x420000000000000000000000000000000000001a`. The original address is now deprecated and not used after the Kroma MPT
hard fork.

### ProtocolVault

The `ProtocolVault` is now deprecated and not used after the Kroma MPT hard fork.

### SequencerFeeVault

The new predeploy `SequencerFeeVault` is introduced with the address `0x4200000000000000000000000000000000000011` after
the Kroma MPT hard fork.

### BaseFeeVault

The new predeploy `BaseFeeVault` is introduced with the address `0x4200000000000000000000000000000000000019` after
the Kroma MPT hard fork.

2 changes: 2 additions & 0 deletions specs/protocol/regolith/overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ The Regolith upgrade, named after a material best described as "deposited dust o
implements minor changes to deposit processing, based on reports of the Sherlock Audit-contest and findings in
the Bedrock Optimism Goerli testnet.

Regolith has been integrated and activated from the genesis block on Kroma.

Summary of changes:

- The `isSystemTx` boolean is disabled, system transactions now use the same gas accounting rules as regular deposits.
Expand Down

0 comments on commit f969656

Please sign in to comment.