-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change API from 'Google API Client' to 'Google Cloud Python Client' #723
Conversation
Not sure if this is part of what you added but at the end of the scenario i got this error
|
I took a look and this comes from here: Line 74 in 462c9ac
There's no |
b8521ff
to
7d84e0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I'll be able to keep working on it tomorrow, so keep tuned and let me know if I can help you with your issue. |
Signed-off-by: Pablo Méndez Hernández <[email protected]>
3406186
to
6e4f3c2
Compare
According to the 'Google API Client' GH page: ``` This library is considered complete and is in maintenance mode. This means that we will address critical bugs and security issues but will not add any new features. This library is officially supported by Google. However, the maintainers of this repository recommend using Cloud Client Libraries for Python, where possible, for new code development. ``` So change the code accordingly to adapt it to 'Google Cloud Python Client'. Signed-off-by: Pablo Méndez Hernández <[email protected]>
/lgtm |
Btw, @paigerube14, have you been able to test if this PR fixes #740 for you? I've just installed a 4.17 cluster and haven't been able to reproduce it. |
With these changes I also wasn't able to reproduce the issue. Thinking this fixes it! |
According to the 'Google API Client' GH page:
So change the code accordingly to adapt it to 'Google Cloud Python Client'.