Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change API from 'Google API Client' to 'Google Cloud Python Client' #723

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

pablomh
Copy link
Contributor

@pablomh pablomh commented Oct 23, 2024

According to the 'Google API Client' GH page:

This library is considered complete and is in maintenance mode. This means
that we will address critical bugs and security issues but will not add any
new features.

This library is officially supported by Google. However, the maintainers of
this repository recommend using Cloud Client Libraries for Python, where
possible, for new code development.

So change the code accordingly to adapt it to 'Google Cloud Python Client'.

@paigerube14
Copy link
Collaborator

Not sure if this is part of what you added but at the end of the scenario i got this error

2024-10-23 17:56:45,901 [INFO] Node with instance ID: prubenda-4185-c8qj7-worker-b-mqtcq has been rebooted
2024-10-23 17:56:45,902 [INFO] node_reboot_scenario has been successfuly injected!
2024-10-23 17:56:46,556 [ERROR] 'namespace'

@pablomh
Copy link
Contributor Author

pablomh commented Oct 24, 2024

Not sure if this is part of what you added but at the end of the scenario i got this error

2024-10-23 17:56:45,901 [INFO] Node with instance ID: prubenda-4185-c8qj7-worker-b-mqtcq has been rebooted
2024-10-23 17:56:45,902 [INFO] node_reboot_scenario has been successfuly injected!
2024-10-23 17:56:46,556 [ERROR] 'namespace'

I took a look and this comes from here:

namespaces.extend(krkn_lib.utils.deep_get_attribute("namespace", scenario_config))

There's no namespace in any of the example config files (nor in the one I used and probably the one you used as well), so it complains about it.

@pablomh pablomh force-pushed the google_api branch 3 times, most recently from b8521ff to 7d84e0c Compare October 25, 2024 14:17
Copy link
Collaborator

@paigerube14 paigerube14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@paigerube14
Copy link
Collaborator

@pablomh any updates on this PR? I am hitting an issue with the node scenarios on GCP and wonder if this PR will help fix it/get around it since its using a different library

#740

@pablomh
Copy link
Contributor Author

pablomh commented Dec 10, 2024

I'll be able to keep working on it tomorrow, so keep tuned and let me know if I can help you with your issue.

@pablomh pablomh force-pushed the google_api branch 2 times, most recently from 3406186 to 6e4f3c2 Compare December 12, 2024 15:10
According to the 'Google API Client' GH page:

```
This library is considered complete and is in maintenance mode. This means
that we will address critical bugs and security issues but will not add any
new features.

This library is officially supported by Google. However, the maintainers of
this repository recommend using Cloud Client Libraries for Python, where
possible, for new code development.
```

So change the code accordingly to adapt it to 'Google Cloud Python Client'.

Signed-off-by: Pablo Méndez Hernández <[email protected]>
@paigerube14
Copy link
Collaborator

/lgtm

@pablomh
Copy link
Contributor Author

pablomh commented Dec 12, 2024

Btw, @paigerube14, have you been able to test if this PR fixes #740 for you?

I've just installed a 4.17 cluster and haven't been able to reproduce it.

@paigerube14
Copy link
Collaborator

Btw, @paigerube14, have you been able to test if this PR fixes #740 for you?

I've just installed a 4.17 cluster and haven't been able to reproduce it.

With these changes I also wasn't able to reproduce the issue. Thinking this fixes it!

@chaitanyaenr chaitanyaenr merged commit 667798d into krkn-chaos:main Dec 13, 2024
6 of 7 checks passed
@pablomh pablomh deleted the google_api branch December 19, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants