Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ebs loss scenario #692

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Add ebs loss scenario #692

merged 1 commit into from
Dec 10, 2024

Conversation

jtydlack
Copy link
Collaborator

@jtydlack jtydlack commented Sep 6, 2024

  • Added scenario config
  • Added new folder containing scenarion scripts
  • Added scenario in run_kraken.py and kraken config

Resolves #678

@jtydlack jtydlack force-pushed the detach_ebs_volumes branch 2 times, most recently from 6da4afc to 0fc21a1 Compare October 1, 2024 09:14
@jtydlack jtydlack marked this pull request as ready for review October 2, 2024 09:25
paigerube14
paigerube14 reviewed Oct 2, 2024
View reviewed changes
config/config.yaml Outdated Show resolved Hide resolved
@chaitanyaenr chaitanyaenr requested a review from pablomh October 2, 2024 13:48
@pablomh
Copy link
Contributor

pablomh commented Oct 24, 2024

Is there any reason why this functionality shouldn't be implemented as a new scenario of aws_node_scenarios?

@chaitanyaenr
Copy link
Collaborator

Is there any reason why this functionality shouldn't be implemented as a new scenario of aws_node_scenarios?

Agree with @pablomh that we can make it as an additional action in the node-scenarios - https://github.com/krkn-chaos/krkn/blob/main/scenarios/openshift/aws_node_scenarios.yml where the parameters are similar for aws, gcp, azure - node name to target, volume id etc and we run the detach logic based on cloud_provider set ( aws, gcp etc. )

@jtydlack jtydlack force-pushed the detach_ebs_volumes branch 2 times, most recently from 25b669f to 193a936 Compare November 27, 2024 10:57
pablomh
pablomh reviewed Nov 28, 2024
View reviewed changes
Copy link
Contributor

@pablomh pablomh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I'd like to see the commits squashed so we only see the final work and not the intermediate steps.

docs/node_scenarios.md Show resolved Hide resolved
docs/node_scenarios.md Outdated Show resolved Hide resolved
krkn/scenario_plugins/node_actions/abstract_node_scenarios.py Outdated Show resolved Hide resolved
krkn/scenario_plugins/node_actions/aws_node_scenarios.py Show resolved Hide resolved
run_kraken.py Outdated Show resolved Hide resolved
@jtydlack jtydlack force-pushed the detach_ebs_volumes branch 3 times, most recently from 327f7b1 to aef99fd Compare November 29, 2024 13:19
chaitanyaenr
chaitanyaenr approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@chaitanyaenr chaitanyaenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a test to disrupt volumes on a node with just root disk and it worked as expected!

2024-12-05 12:39:36,924 [INFO] actionnode_disk_detach_attach_scenario
2024-12-05 12:39:36,924 [INFO] Starting disk_detach_attach_scenario injection
2024-12-05 12:39:36,924 [INFO] Obtaining disk attachment information
2024-12-05 12:39:37,277 [ERROR] Node ip-10-0-30-109.us-west-2.compute.internal has only root disk attached
2024-12-05 12:39:37,277 [ERROR] node_disk_detach_attach_scenario failed!
2024-12-05 12:39:37,481 [INFO] wating 60 before running the next scenario

Minor nit. Other than that LGTM! Nice work @juliemathew!

@jtydlack
Add node_disk_detach_attach_scenario for aws under node scenarios
520ac52 
Resolves krkn-chaos#678

Signed-off-by: jtydlack <[email protected]>

Add functions for aws detach disk scenario

Signed-off-by: jtydlack <[email protected]>

Add detach disk scenario in node scenario

Signed-off-by: jtydlack <[email protected]>

Add disk_deatch_attach_scenario in docs

Signed-off-by: jtydlack <[email protected]>
@pablomh
Copy link
Contributor

pablomh commented Dec 10, 2024

Now that the commits are squashed, LGTM :)

@chaitanyaenr chaitanyaenr merged commit 0c30d89 into krkn-chaos:main Dec 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paigerube14 paigerube14 paigerube14 left review comments

@pablomh pablomh pablomh left review comments

@chaitanyaenr chaitanyaenr chaitanyaenr approved these changes

@tsebastiani tsebastiani Awaiting requested review from tsebastiani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scenario to detach EBS volumes
4 participants
@jtydlack @pablomh @chaitanyaenr @paigerube14