Service disruption #494
Merged
Service disruption #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paigerube14
force-pushed
the
service_disruption
branch
from
19ceb15 to
267badc
Compare
|
@paigerube14 let's update docs with scenario name as well as functionality changes: https://github.com/redhat-chaos/krkn/blob/main/docs/namespace_scenarios.md#delete-namespace-scenarios. Also here: https://github.com/redhat-chaos/krkn#kubernetesopenshift-chaos-scenarios-supported. Thoughts? |
chaitanyaenr
reviewed
Oct 6, 2023
chaitanyaenr
approved these changes
Oct 6, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chaitanyaenr, paigerube14 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
chaitanyaenr
reviewed
Oct 6, 2023
chaitanyaenr
reviewed
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the namespace scenario to delete objects in the namespace instead of the whole namespace to not need to edit the namespace to remove the finalizer.
These changes will be able to list object types and the ability to remove the larger object types (deployment, replica set and statefulset) as well as services