Skip to content

Commit

Permalink
test: fix qunit start the test too early
Browse files Browse the repository at this point in the history
Now that the markdown plugin is async, the ready events are not fired quick enough for the assertions to be register before qunit start running the tests.

The solution is to have all decks resolve their promise when they finish register the tests. The qunit is then instructed to wait on these promises to be resovled before starting the test.
  • Loading branch information
krerkkiat committed Mar 6, 2024
1 parent c03c6a8 commit eb09281
Show file tree
Hide file tree
Showing 2 changed files with 157 additions and 132 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<img src="https://hakim-static.s3.amazonaws.com/reveal-js/logo/v1/reveal-black-text-sticker.png" alt="reveal.js" width="500">
</a>
<br><br>
<a href="https://github.com/hakimel/reveal.js/actions"><img src="https://github.com/hakimel/reveal.js/workflows/tests/badge.svg"></a>
<a href="https://github.com/krerkkiat/reveal.js-ou-eecs/actions"><img src="https://github.com/krerkkiat/reveal.js-ou-eecs/workflows/tests/badge.svg"></a>
<a href="https://slides.com/"><img src="https://s3.amazonaws.com/static.slid.es/images/slides-github-banner-320x40.png?1" alt="Slides" width="160" height="20"></a>
</p>

Expand Down
Loading

0 comments on commit eb09281

Please sign in to comment.