Fix utf-8 decoder

kregfile · May 12, 2018 · ed9cb3b · ed9cb3b
1 parent 25fcda6
commit ed9cb3b
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/browser/decode.js b/browser/decode.js
@@ -23,7 +23,7 @@ function utf8Read(view, offset, length) {
     }
     if ((byte & 0xe0) === 0xc0) {
       string += String.fromCharCode(
-        ((byte & 0x0f) << 6) |
+        ((byte & 0x1f) << 6) |
         (view.getUint8(++i) & 0x3f)
       );
       continue;

diff --git a/dist/notepack.js b/dist/notepack.js
diff --git a/dist/notepack.js.map b/dist/notepack.js.map
diff --git a/test/browser.js b/test/browser.js
@@ -50,6 +50,17 @@ describe('notepack (browser build)', function() {
     expect(notepack.encode(obj)).to.deep.equal(notepack.encode('c'));
   });
 
+  it('utf-8', function() {
+    // 1-byte
+    expect(notepack.decode(notepack.encode('äß'))).to.equal('äß');
+    // 2-byte
+    expect(notepack.decode(notepack.encode('עִבְרִית'))).to.equal('עִבְרִית');
+    // 3-byte
+    expect(notepack.decode(notepack.encode('\u13DA'))).to.equal('\u13DA');
+    // 4-byte
+    expect(notepack.decode(notepack.encode('🌐'))).to.equal('🌐');
+  });
+
   it('all formats', function () {
     this.timeout(20000);
     var expected = {