Update deps, adapt to newer versions, fix clippy #77
Conversation
And change default k8s-openapi feature to v1_24 as the older versions were dropped. Also update the code for newer cargo/rust. And fix what cargo clippy suggests. Signed-off-by: Martin Kletzander <[email protected]>
Signed-off-by: Martin Kletzander <[email protected]>
nertpinx
requested review from
thomastaylor312,
bacongobbler and
kflansburg
as code owners
|
I am also very curious what you found it useful for! |
|
I need a virtual kubelet and wanted to use krustlet due to me and the Rust language usually being in more agreement than with Go. I also needed to update the dependencies there and make it buildable with newer rust/cargo since that project is not actively maintained. I understand the possible issues, however I'm just using these to do a proof of concept. Moreover the interesting functionality will be in another binary/repository so I'm using krustlet to really simply fake that pods are running. Feel free to check out my repository of krustlet but bear in mind that the code is very rough, the commits are not descriptive, and so on. I am unable to send a proper PR to krustlet because in order to update it properly I would have to rewrite the WASM handling due to the need to switch to another backend. In my branch I removed the wasi part completely. What I might use krator for later is handling of the state machine of my CRD objects, unless I have the need for finalizers and other things that are, to the best of my knowledge, not handled in krator. On the other hand, to be honest, if the other idea ends with the PoC, or if I need a current, stable, and updated stack I might not use krator (or krustlet) at all in the end. I just figured I might as well polish the update to krator and contribute it back, just in case it helps someone else or someone wants to get back to it at some point =) |
|
Looks like the failures are all from features not being enabled on the openapi crate |
|
The documentation tests fail because Build tests fail because the tests do not enable any of the 'v1_*' features of k8s-openapi and the test runs I have an idea how to fix it, but I'm not sure if it's the best way. |
|
@nertpinx Feel free to try whatever feels best! |
I am not sure whether this project, in its current state, accepts PRs, but the idea behind it is very nice and since I just used it for some testing I want to contribute some updates back upstream.