IDMUS cheat support UMAPINFO #549
Open
+63
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prboom2/src/dsda/mapinfo/u.c
Outdated
| int lump; | ||
| struct MapEntry* entry = dsda_UMapEntry(episode, map); | ||
| int level_num; |
There was a problem hiding this comment.
Do we need int level_num here?
There was a problem hiding this comment.
We don't. I missed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on discord. Fixes IDMUS only playing IWAD lumps
The dsda_*Music() functions were hardcoded to only use the current map, so I adapted dsda_MapMusic() to take any map.
Maybe we should do the same for the others, but I can't think of a reason we would need to call them with a map param.