Skip to content

Add make targets for go workspaces, gosec targets use go run instead of container, run make fix-all - #1149

Open
mozesl-nokia wants to merge 2 commits into
kptdev:mainfrom
nokia:gosec-gowork
Open

Add make targets for go workspaces, gosec targets use go run instead of container, run make fix-all#1149
mozesl-nokia wants to merge 2 commits into
kptdev:mainfrom
nokia:gosec-gowork

Conversation

@mozesl-nokia

Copy link
Copy Markdown
Contributor

Add make targets for go workspaces, gosec targets use go run instead of container, run make fix-all


Description

  • What changed: Added new make targets, ran the fix-all target
  • Why it’s needed: The current way gosec is invoked is "inefficient"; a lot of code in the repo did not have fixes applied
  • How it works:
    • The go.work make target creates the workspace with the appropriate modules
    • The gosec targets now use the local gosec install or go run like the linter
      • The version check here would be difficult, since without explicit -ldflags the gosec -version puts out "dev" (still possible through go version -m, put complicated)

Related Issue(s)

  • None

Type of Change

  • Refactor

Checklist

  • Code follows project style guidelines
  • Self-reviewed changes
  • Tests added/updated
  • Documentation added/updated
  • All tests and gating checks pass

Additional Notes (Optional)

  • Known issues: If you have a newer local gosec installed, you will get additional vulnerability errors

AI Disclosure

  • I have used AI in the creation of this PR.

If so, please describe how:

  • Cursor's Grok 4.5 was used to refactor the gosec make targets

Assisted-by: Cursor:grok-4.5
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
Signed-off-by: Mózes László Máté <laszlo.mozes@nokia.com>
@mozesl-nokia
mozesl-nokia requested review from a team August 10, 2026 14:51
@mozesl-nokia mozesl-nokia added the go Pull requests that update go code label Aug 10, 2026
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 10, 2026
@netlify

netlify Bot commented Aug 10, 2026

Copy link
Copy Markdown

Deploy Preview for kpt-porch ready!

Name Link
🔨 Latest commit 457b313
🔍 Latest deploy log https://app.netlify.com/projects/kpt-porch/deploys/6a79e587430ecb00089ddc24
😎 Deploy Preview https://deploy-preview-1149--kpt-porch.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
73.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup go Pull requests that update go code refactoring #b33d8f size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant