Skip to content

Replace 'GoogleContainerTools' references with 'kptdev' in kpt repo #4196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 4, 2025

Conversation

liamfallon
Copy link
Contributor

@liamfallon liamfallon commented May 26, 2025

This PR replaces references to GoogleContainerTools with kptdev.Apologies for the size of this PR but this has to be done in one big PR.

  • The code builds locally and the linting works
  • GoogleContainerTools has a kpt-config-sync repo, references to this repo were not removed for now until we decide what to do with it, ti may be a kpt clone of the regular configsync
  • golang and linter versions are updated due to out of date versions throwing errors
  • the sub-module "rollouts" is disable because the kpt main module refers to packages in it and it refers to "kptdev" packages in the kpt main module that are not in Github until this PR is merged (circular module dependency). Once this PR is merged, the "rollout" module can be re-enabled and merged
  • Some small lint errors showing up in the code due to the bump in the linter version have been fixed
  • The Porch API is now imported from the Nephio porch
  • Downgrade image: "k8s.gcr.io/pause:2.0" to "image: k8s.gcr.io/pause:1.0" in live end to end test data to avoid Docker metadata type error.
  • Dependencies updated in go.mod

@liamfallon liamfallon requested a review from kispaljr as a code owner May 26, 2025 15:52
Copy link

@kispaljr kispaljr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I obviously haven't read through all the changes one-by-one, but based on the few key files I checked and your comments looks good to me.

liamfallon and others added 10 commits June 4, 2025 14:30
Co-authored-by: Gergely Csatari <[email protected]>
Signed-off-by: liamfallon <[email protected]>
Co-authored-by: Gergely Csatari <[email protected]>
Signed-off-by: liamfallon <[email protected]>
Co-authored-by: Gergely Csatari <[email protected]>
Signed-off-by: liamfallon <[email protected]>
Co-authored-by: Gergely Csatari <[email protected]>
Signed-off-by: liamfallon <[email protected]>
Co-authored-by: Gergely Csatari <[email protected]>
Signed-off-by: liamfallon <[email protected]>
Co-authored-by: Gergely Csatari <[email protected]>
Signed-off-by: liamfallon <[email protected]>
liamfallon and others added 3 commits June 4, 2025 14:30
Co-authored-by: Gergely Csatari <[email protected]>
Signed-off-by: liamfallon <[email protected]>
Co-authored-by: Gergely Csatari <[email protected]>
Signed-off-by: liamfallon <[email protected]>
@kispaljr kispaljr merged commit 9347753 into kptdev:main Jun 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants