Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default target Python version to 3.9 #2271

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ncoghlan
Copy link
Contributor

Python 3.8 reached end-of-life in October 2024.

typing.Annotated was added in Python 3.9, so using annotations will no longer need typing_extensions by default.

Python 3.8 reached end-of-life in October 2024.

`typing.Annotated` was added in Python 3.9, so using annotations
will no longer need `typing_extensions` by default.
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dd92cd0) to head (207e2c2).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2271   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         4307      4307           
  Branches       994       994           
=========================================
  Hits          4307      4307           
Flag Coverage Δ
unittests 99.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ncoghlan
Copy link
Contributor Author

Not an urgent change, I just got bitten by other projects no longer depending on typing-extensions in Python 3.13, which meant I noticed my own dependency that I had inadvertently picked up by generating code compatible with a Python version I didn't support anyway.

@ncoghlan ncoghlan marked this pull request as draft January 16, 2025 03:49
@ncoghlan
Copy link
Contributor Author

Reverted to draft, as the CI failure indicates there's more to this change than just bumping the default value.

Copy link

codspeed-hq bot commented Jan 16, 2025

CodSpeed Performance Report

Merging #2271 will not alter performance

Comparing ncoghlan:patch-1 (207e2c2) with main (dd92cd0)

Summary

✅ 31 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant