Improve finding of Cabal files #585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an unlikely event of several Cabal file in the same folder Stan currently chooses to return the first of them, but inadverently forgets to prepend a directory name. Merging (x : _xs) case with [cabalFile] has a nice side effect of making the search a bit faster: previous version of the code would necessarily scan the entire folder looking for the second Cabal file (because if it is to be found, outcomes will be different), but now we shall stop after finding the first one. Related to haskell/haskell-language-server#4515
.git folder can contain a maze of thousands of subfolders, this is definitely not a place to look for Cabal files. Related to haskell/haskell-language-server#4515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix haskell/haskell-language-server#4515 or at least eliminate a few suspects.